-
Notifications
You must be signed in to change notification settings - Fork 82
Proof of concept groth16 verifier #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment relating to potential API traps and if there's an opportunity to improve either the example of the SDK. I'm not the best person to review the groth specifics. Do we have anyone else who is up on that? Otherwise I can approve.
github-merge-queue bot
pushed a commit
to stellar/rs-soroban-sdk
that referenced
this pull request
May 9, 2025
### What Split out point negation part ([0945897](0945897)) from #1449, and address review comments on this part. ### Why Improves usability of the BLS12-381 features in a Groth16 verifier application ([example contract](stellar/soroban-examples#350)) - `Neg` is an common operation, needed for using the proof parameter as pairing input, and is cheap and simple enough to be implemented as an sdk function. ### Known limitations [TODO or N/A]
github-merge-queue bot
pushed a commit
to stellar/rs-soroban-sdk
that referenced
this pull request
May 16, 2025
### What Add support for BLS12-381 curve points (`Fp`, `Fp2`, `G1Affine`, `G2Affine`, `Fr`) for internal data storage (via `contracttype`) and contract invocation arguments (contract spec). ### Why Improves usability of the BLS12-381 features in a Groth16 verifier application ([example contract](stellar/soroban-examples#350)) - `Arbitrary` and several missing conversions are needed to use `G1Affine`, `G2Affine` as contract data. ### Known limitations [TODO or N/A] --------- Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com>
update link fmt clean up and update improve writing
leighmcculloch
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Implements a Groth16 verifier contract, and in the test verifies a simple proof generated off-chain.
See README for how the proof and verification data was generated.
Here is the demo
Why
This implementation demonstrates the BLS12-381 curve operations in Soroban, enabling zero-knowledge proof verification on-chain. The simple multiplication circuit (
a * b = c
) serves as a proof-of-concept for more complex ZK applications.Known limitations
[TODO or N/A]