Skip to content

Conversation

karolyi
Copy link
Contributor

@karolyi karolyi commented Sep 23, 2025

  • Remove fuzzy markers from de locale messages for national/international phone number validation in form fields.
  • Refine German translations for phone number input prompts to include international prefix examples.
  • Introduce new hu locale django.po with translations for form fields, model fields, serializer fields, and validators for phone numbers.

@karolyi
Copy link
Contributor Author

karolyi commented Sep 23, 2025

Really nigga... Coverals shitting the bed isn't really my problem and it seems it does it even if I restart the pipeline (force-push).

Please merge & release ASAP, losing german translations are a blunder. I took the opportunity and added hungarian translations too, being trilingual.

@francoisfreitag
Copy link
Collaborator

Thanks! An earlier PR was addressing more locales. I merged it, then rebased your branch on it.
The addition of the Hungarian locale remains, can you double check both German and Hungarian locales look correct to you?

@francoisfreitag francoisfreitag changed the title Fix German PO file and add Hungarian locale Add Hungarian locale Oct 1, 2025
@karolyi
Copy link
Contributor Author

karolyi commented Oct 1, 2025

Yes, I was following what you've been doing (getting emails) and things look good.

Just a humble advice, you want to use --add-location file when extracting messages, so the .po files wouldn't change with every code line skewing, as the line numbers wouldn't be there.

@francoisfreitag francoisfreitag merged commit bc1b08a into stefanfoulis:main Oct 1, 2025
16 checks passed
francoisfreitag added a commit to francoisfreitag/django-phonenumber-field that referenced this pull request Oct 1, 2025
The lines can easily change with code change, which requires updating
the messages file frequently.

Keep the file as a pointer to help technical-savvy translators find the
message context, but without a line number. They’ll be able to search
within the file easily.

Messages were collected with:
```
django-admin makemessages --all --add-location=file
```

Recommended-by: stefanfoulis#643 (comment)
@francoisfreitag
Copy link
Collaborator

Just a humble advice, you want to use --add-location file when extracting messages, so the .po files wouldn't change with every code line skewing, as the line numbers wouldn't be there.

Thanks for the advice, proposed in #644.

@karolyi karolyi deleted the master branch October 1, 2025 16:12
francoisfreitag added a commit that referenced this pull request Oct 2, 2025
The lines can easily change with code change, which requires updating
the messages file frequently.

Keep the file as a pointer to help technical-savvy translators find the
message context, but without a line number. They’ll be able to search
within the file easily.

Messages were collected with:
```
django-admin makemessages --all --add-location=file
```

Recommended-by: #643 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants