Split markdown into blocks so that checkboxes are singled out #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-niedermann
requested changes
Jan 5, 2024
There was a problem hiding this comment.
- Please use Java only in this library. There are good reasons to use Kotlin, but this library module is Java only and I do not want to mix it up.
- Please add at least one unit test for your method, better a few more with some edge cases (
nullor emptycontentparameter)-
| import java.util.ArrayList | ||
|
|
||
| class RemoteViewElement( | ||
| val type: Int, |
| @@ -159,14 +226,21 @@ private static String runForEachCheckbox(@NonNull String markdownString, @NonNul | |||
| } | |||
| } | |||
| if (!isInFencedCodeBlock) { | |||
| if (lineStartsWithCheckbox(lines[i]) && lines[i].trim().length() > EListType.DASH.checkboxChecked.length()) { | |||
There was a problem hiding this comment.
I wonder why I used to only consider EListType.DASH... This should maybe refactored to loop through the EListType enum.... however, nothing you will have to fix here :)
|
Merged in #245 (I also fixed the review items I made) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will seperate the markdown into different RemoteViewElements.
Each RemoteViewElement has a type and a text. The text corresponds to the raw, unrendered markdown, and the type will allow the result to be used more precisely.
I did this, so that i could implement checkboxes:
I develop this library-extension in tandem with the actual widget. So while this is not really a draft, i would not merge this yet until i got the actual feature to be reviewed on the app-side.
See: nextcloud/notes-android#1912