Skip to content

chore: fix JavaScript lint errors (issue #7553) #7734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 25, 2025

Conversation

siddhesh434
Copy link
Contributor

Resolves #7553.

Description

What is the purpose of this pull request?

This pull request:

  • Fixes a JavaScript lint error where TransformStream was being reported as "already defined" by renaming the imported variable to StdlibTransformStream. This avoids conflicts with potential global or built-in TransformStream objects.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Jul 24, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jul 24, 2025

Coverage Report

Package Statements Branches Functions Lines
bench/harness $\color{green}513/513$
$\color{green}+100.00\%$
$\color{green}60/60$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}513/513$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Signed-off-by: Athan <kgryte@gmail.com>
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up. In this case, the appropriate course of action was just disabling the lint rule.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jul 25, 2025
@kgryte kgryte merged commit aa8d147 into stdlib-js:develop Jul 25, 2025
10 checks passed
@siddhesh434
Copy link
Contributor Author

Hi Athan,
Thank you very much for your feedback! This was my first contribution, and I’m currently learning the GitHub workflow and how to contribute effectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors
3 participants