Skip to content

feat: add C implementation for blas/base/dsyr #6566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 49 commits into from
Jul 11, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
9651a1a
feat: add c implementation for blas/base/dsyr
ShabiShett07 Apr 5, 2025
c10bded
feat: add c implementation for blas/base/dsyr
ShabiShett07 Apr 5, 2025
c6e3f16
fix: file permissions
ShabiShett07 Apr 5, 2025
ac5310c
remove: floating point
ShabiShett07 Apr 5, 2025
9c4b307
chore: update implementation
ShabiShett07 May 7, 2025
ce571b1
chore: minor changes
ShabiShett07 May 7, 2025
635d2af
chore: change datatypes
ShabiShett07 May 7, 2025
e5ef119
chore: update implementation
ShabiShett07 May 7, 2025
a66e7ab
chore: update jsdoc
ShabiShett07 May 7, 2025
a92e9d0
chore: update datatypes
ShabiShett07 May 7, 2025
5226edb
chore: add indentation
ShabiShett07 May 7, 2025
f93b8a7
chore: update implementation
ShabiShett07 May 30, 2025
149b5d9
chore: update implementation
ShabiShett07 May 30, 2025
d0b30b1
chore: minor clean-up
ShabiShett07 May 30, 2025
aef4a1d
remove: whitespace
ShabiShett07 May 30, 2025
291cee5
chore: clean-up
ShabiShett07 Jun 28, 2025
51b7a4b
chore: minor clean-up
ShabiShett07 Jun 28, 2025
aecaa92
chore: minor clean-up
ShabiShett07 Jun 28, 2025
add2333
c
ShabiShett07 Jun 28, 2025
6c831d5
chore: minor clean-up
ShabiShett07 Jun 28, 2025
81acffa
chore: minor clean-up
ShabiShett07 Jun 28, 2025
93409ab
chore: minor clean-up
ShabiShett07 Jun 28, 2025
15f4a28
chore: minor clean-up
ShabiShett07 Jun 28, 2025
893a336
chore: minor clean-up
ShabiShett07 Jun 28, 2025
1e78d95
chore: minor clean-up\
ShabiShett07 Jun 28, 2025
f3bbcea
chore: minor clean-up
ShabiShett07 Jun 28, 2025
8d5d2e7
chore: add checks
ShabiShett07 Jun 29, 2025
3c6f996
chore: clean-up
ShabiShett07 Jun 29, 2025
e1ddd8a
chore: clean-up
ShabiShett07 Jun 29, 2025
09b7e71
Merge branch 'develop' into feature/dsyr
ShabiShett07 Jun 29, 2025
6534b3f
chore: minor clean-up
ShabiShett07 Jun 29, 2025
3df6b71
chore: minor clean-up
ShabiShett07 Jun 29, 2025
b179a4f
chore: minor clean-up
ShabiShett07 Jun 29, 2025
8d3d1b6
chore: minor clean-up
ShabiShett07 Jun 29, 2025
1f027ac
chore: minor clean-up
ShabiShett07 Jun 30, 2025
4f4f057
chore: add suggestions
ShabiShett07 Jun 30, 2025
cd4c878
chore: add suggestions
ShabiShett07 Jun 30, 2025
d871fbd
chore: update jsdoc
ShabiShett07 Jun 30, 2025
9edb8f3
Apply suggestions from code review
kgryte Jul 11, 2025
1e76bd7
docs: update comment
kgryte Jul 11, 2025
2ebc225
docs: update comment
kgryte Jul 11, 2025
5a20e0f
docs: update comment
kgryte Jul 11, 2025
520a1fb
docs: update comments
kgryte Jul 11, 2025
b371c63
docs: update comment
kgryte Jul 11, 2025
dfd8998
Apply suggestions from code review
kgryte Jul 11, 2025
6ef0e5d
docs: fix alignment
kgryte Jul 11, 2025
3a09ffe
docs: update description
kgryte Jul 11, 2025
c18fde2
docs: update description
kgryte Jul 11, 2025
33e7723
docs: update comment
kgryte Jul 11, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
140 changes: 115 additions & 25 deletions lib/node_modules/@stdlib/blas/base/dsyr/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ Performs the symmetric rank 1 operation `A = α*x*x^T + A` where `α` is a scala
```javascript
var Float64Array = require( '@stdlib/array/float64' );

var A = new Float64Array( [ 1.0, 2.0, 3.0, 0.0, 1.0, 2.0, 0.0, 0.0, 1.0 ] );
var A = new Float64Array( [ 1.0, 2.0, 3.0, 2.0, 1.0, 2.0, 3.0, 2.0, 1.0 ] );
var x = new Float64Array( [ 1.0, 2.0, 3.0 ] );

dsyr( 'row-major', 'upper', 3, 1.0, x, 1, A, 3 );
// A => <Float64Array>[ 2.0, 4.0, 6.0, 0.0, 5.0, 8.0, 0.0, 0.0, 10.0 ]
// A => <Float64Array>[ 2.0, 4.0, 6.0, 2.0, 5.0, 8.0, 3.0, 2.0, 10.0 ]
```

The function has the following parameters:
Expand All @@ -51,20 +51,20 @@ The function has the following parameters:
- **N**: number of elements along each dimension of `A`.
- **α**: scalar constant.
- **x**: input [`Float64Array`][mdn-float64array].
- **sx**: index increment for `x`.
- **sx**: stride length for `x`.
- **A**: input matrix stored in linear memory as a [`Float64Array`][mdn-float64array].
- **lda**: stride of the first dimension of `A` (a.k.a., leading dimension of the matrix `A`).

The stride parameters determine how elements in the input arrays are accessed at runtime. For example, to iterate over every other element of `x` in reverse order,
The stride parameters determine how elements in the input arrays are accessed at runtime. For example, to iterate over the elements of `x` in reverse order,

```javascript
var Float64Array = require( '@stdlib/array/float64' );

var A = new Float64Array( [ 1.0, 2.0, 3.0, 0.0, 1.0, 2.0, 0.0, 0.0, 1.0 ] );
var x = new Float64Array( [ 1.0, 2.0, 3.0, 4.0, 5.0 ] );
var A = new Float64Array( [ 1.0, 2.0, 3.0, 2.0, 1.0, 2.0, 3.0, 2.0, 1.0 ] );
var x = new Float64Array( [ 3.0, 2.0, 1.0 ] );

dsyr( 'row-major', 'upper', 3, 1.0, x, -2, A, 3 );
// A => <Float64Array>[ 26.0, 17.0, 8.0, 0.0, 10.0, 5.0, 0.0, 0.0, 2.0 ]
dsyr( 'row-major', 'upper', 3, 1.0, x, -1, A, 3 );
// A => <Float64Array>[ 2.0, 4.0, 6.0, 2.0, 5.0, 8.0, 3.0, 2.0, 10.0 ]
```

Note that indexing is relative to the first index. To introduce an offset, use [`typed array`][mdn-typed-array] views.
Expand All @@ -75,14 +75,14 @@ Note that indexing is relative to the first index. To introduce an offset, use [
var Float64Array = require( '@stdlib/array/float64' );

// Initial arrays...
var x0 = new Float64Array( [ 1.0, 1.0, 1.0, 1.0 ] );
var A = new Float64Array( [ 1.0, 2.0, 3.0, 0.0, 1.0, 2.0, 0.0, 0.0, 1.0 ] );
var x0 = new Float64Array( [ 0.0, 3.0, 2.0, 1.0 ] );
var A = new Float64Array( [ 1.0, 2.0, 3.0, 2.0, 1.0, 2.0, 3.0, 2.0, 1.0 ] );

// Create offset views...
var x1 = new Float64Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element

dsyr( 'row-major', 'upper', 3, 1.0, x1, -1, A, 3 );
// A => <Float64Array>[ 2.0, 3.0, 4.0, 0.0, 2.0, 3.0, 0.0, 0.0, 2.0 ]
// A => <Float64Array>[ 2.0, 4.0, 6.0, 2.0, 5.0, 8.0, 3.0, 2.0, 10.0 ]
```

#### dsyr.ndarray( uplo, N, α, x, sx, ox, A, sa1, sa2, oa )
Expand All @@ -92,11 +92,11 @@ Performs the symmetric rank 1 operation `A = α*x*x^T + A`, using alternative in
```javascript
var Float64Array = require( '@stdlib/array/float64' );

var A = new Float64Array( [ 1.0, 2.0, 3.0, 0.0, 1.0, 2.0, 0.0, 0.0, 1.0 ] );
var A = new Float64Array( [ 1.0, 2.0, 3.0, 2.0, 1.0, 2.0, 3.0, 2.0, 1.0 ] );
var x = new Float64Array( [ 1.0, 2.0, 3.0 ] );

dsyr.ndarray( 'upper', 3, 1.0, x, 1, 0, A, 3, 1, 0 );
// A => <Float64Array>[ 2.0, 4.0, 6.0, 0.0, 5.0, 8.0, 0.0, 0.0, 10.0 ]
// A => <Float64Array>[ 2.0, 4.0, 6.0, 2.0, 5.0, 8.0, 3.0, 2.0, 10.0 ]
```

The function has the following additional parameters:
Expand All @@ -111,11 +111,11 @@ While [`typed array`][mdn-typed-array] views mandate a view offset based on the
```javascript
var Float64Array = require( '@stdlib/array/float64' );

var A = new Float64Array( [ 1.0, 2.0, 3.0, 0.0, 1.0, 2.0, 0.0, 0.0, 1.0 ] );
var A = new Float64Array( [ 1.0, 2.0, 3.0, 2.0, 1.0, 2.0, 3.0, 2.0, 1.0 ] );
var x = new Float64Array( [ 1.0, 2.0, 3.0, 4.0, 5.0 ] );

dsyr.ndarray( 'upper', 3, 1.0, x, -2, 4, A, 3, 1, 0 );
// A => <Float64Array>[ 26.0, 17.0, 8.0, 0.0, 10.0, 5.0, 0.0, 0.0, 2.0 ]
// A => <Float64Array>[ 26.0, 17.0, 8.0, 2.0, 10.0, 5.0, 3.0, 2.0, 2.0 ]
```

</section>
Expand Down Expand Up @@ -149,11 +149,18 @@ var opts = {

var N = 3;

var A = ones( N*N, opts.dtype );
// Create N-by-N symmetric matrices:
var A1 = ones( N*N, opts.dtype );
var A2 = ones( N*N, opts.dtype );

// Create a random vector:
var x = discreteUniform( N, -10.0, 10.0, opts );

dsyr( 'row-major', 'upper', 3, 1.0, x, 1, A, 3 );
console.log( A );
dsyr( 'row-major', 'upper', 3, 1.0, x, 1, A1, 3 );
console.log( A1 );

dsyr.ndarray( 'upper', 3, 1.0, x, 1, 0, A2, 3, 1, 0 );
console.log( A2 );
```

</section>
Expand Down Expand Up @@ -183,21 +190,65 @@ console.log( A );
### Usage

```c
TODO
#include "stdlib/blas/base/dsyr.h"
```

#### TODO
#### c_dsyr( layout, uplo, N, alpha, \*X, sx, \*A, LDA )

TODO.
Performs the symmetric rank 1 operation `A = α*x*x^T + A` where `α` is a scalar, `x` is an `N` element vector, and `A` is an `N` by `N` symmetric matrix.

```c
TODO
#include "stdlib/blas/base/shared.h"

double A[] = { 1.0, 2.0, 3.0, 2.0, 1.0, 2.0, 3.0, 2.0, 1.0 };
const double x[] = { 1.0, 2.0, 3.0 };

c_dsyr( CblasColMajor, CblasUpper, 3, 1.0, x, 1, A, 3 );
```

TODO
The function accepts the following arguments:

- **layout**: `[in] CBLAS_LAYOUT` storage layout.
- **uplo**: `[in] CBLAS_UPLO` specifies whether the upper or lower triangular part of the symmetric matrix `A` should be referenced.
- **N**: `[in] CBLAS_INT` number of elements along each dimension of `A`.
- **alpha**: `[in] double` scalar constant.
- **X**: `[in] double*` input array.
- **sx**: `[in] CBLAS_INT` stride length for `X`.
- **A**: `[inout] double*` input matrix.
- **LDA**: `[in] CBLAS_INT` stride of the first dimension of `A` (a.k.a., leading dimension of the matrix `A`).

```c
void c_dsyr( const CBLAS_LAYOUT layout, const CBLAS_UPLO uplo, const CBLAS_INT N, const double alpha, const double *X, const CBLAS_INT strideX, double *A, const CBLAS_INT LDA )
```

#### c_dsyr_ndarray( uplo, N, alpha, \*X, sx, ox, \*A, sa1, sa2, oa )

Performs the symmetric rank 1 operation `A = α*x*x^T + A`, using alternative indexing semantics and where `α` is a scalar, `x` is an `N` element vector, and `A` is an `N` by `N` symmetric matrix.

```c
#include "stdlib/blas/base/shared.h"

double A[] = { 1.0, 2.0, 3.0, 2.0, 1.0, 2.0, 3.0, 2.0, 1.0 };
const double x[] = { 1.0, 2.0, 3.0 };

c_dsyr_ndarray( CblasUpper, 3, 1.0, x, 1, 0, A, 3, 1, 0 );
```

The function accepts the following arguments:

- **uplo**: `[in] CBLAS_UPLO` specifies whether the upper or lower triangular part of the symmetric matrix `A` should be referenced.
- **N**: `[in] CBLAS_INT` number of elements along each dimension of `A`.
- **alpha**: `[in] double` scalar constant.
- **X**: `[in] double*` input array.
- **sx**: `[in] CBLAS_INT` stride length for `X`.
- **ox**: `[in] CBLAS_INT` starting index for `X`.
- **A**: `[inout] double*` input matrix.
- **sa1**: `[in] CBLAS_INT` stride of the first dimension of `A`.
- **sa2**: `[in] CBLAS_INT` stride of the second dimension of `A`.
- **oa**: `[in] CBLAS_INT` starting index for `A`.

```c
TODO
void c_dsyr_ndarray( const CBLAS_UPLO uplo, const CBLAS_INT N, const double alpha, const double *X, const CBLAS_INT strideX, const CBLAS_INT offsetX, double *A, const CBLAS_INT strideA1, const CBLAS_INT strideA2, const CBLAS_INT offsetA )
```

</section>
Expand All @@ -219,7 +270,46 @@ TODO
### Examples

```c
TODO
#include "stdlib/blas/base/dsyr.h"
#include "stdlib/blas/base/shared.h"
#include <stdio.h>

int main( void ) {
// Define 3x3 symmetric matrices stored in row-major layout:
double A1[ 3*3 ] = {
1.0, 2.0, 3.0,
2.0, 1.0, 2.0,
3.0, 2.0, 1.0
};

double A2[ 3*3 ] = {
1.0, 2.0, 3.0,
2.0, 1.0, 2.0,
3.0, 2.0, 1.0
};

// Define a vector:
const double x[ 3 ] = { 1.0, 2.0, 3.0 };

// Specify the number of elements along each dimension of `A1` and `A2`:
const int N = 3;

// Perform the symmetric rank 1 operation `A = α*x*x^T + A`:
c_dsyr( CblasColMajor, CblasUpper, N, 1.0, x, 1, A1, N );

// Print the result:
for ( int i = 0; i < N*N; i++ ) {
printf( "A1[ %i ] = %f\n", i, A1[ i ] );
}

// Perform the symmetric rank 1 operation `A = α*x*x^T + A` using alternative indexing semantics:
c_dsyr_ndarray( CblasUpper, N, 1.0, x, 1, 0, A2, N, 1, 0 );

// Print the result:
for ( int i = 0; i < N*N; i++ ) {
printf( "A2[ %i ] = %f\n", i, A[ i ] );
}
}
```

</section>
Expand Down
109 changes: 109 additions & 0 deletions lib/node_modules/@stdlib/blas/base/dsyr/benchmark/benchmark.native.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,109 @@
/**
* @license Apache-2.0
*
* Copyright (c) 2025 The Stdlib Authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

'use strict';

// MODULES //

var resolve = require( 'path' ).resolve;
var bench = require( '@stdlib/bench' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var ones = require( '@stdlib/array/ones' );
var pow = require( '@stdlib/math/base/special/pow' );
var floor = require( '@stdlib/math/base/special/floor' );
var tryRequire = require( '@stdlib/utils/try-require' );
var pkg = require( './../package.json' ).name;


// VARIABLES //

var dsyr = tryRequire( resolve( __dirname, './../lib/dsyr.native.js' ) );
var opts = {
'skip': ( dsyr instanceof Error )
};
var options = {
'dtype': 'float64'
};


// FUNCTIONS //

/**
* Creates a benchmark function.
*
* @private
* @param {PositiveInteger} N - number of elements along each dimension
* @returns {Function} benchmark function
*/
function createBenchmark( N ) {
var x = ones( N, options.dtype );
var A = ones( N*N, options.dtype );
return benchmark;

/**
* Benchmark function.
*
* @private
* @param {Benchmark} b - benchmark instance
*/
function benchmark( b ) {
var z;
var i;

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
z = dsyr( 'row-major', 'upper', N, 1.0, x, 1, A, N );
if ( isnan( z[ i%z.length ] ) ) {
b.fail( 'should not return NaN' );
}
}
b.toc();
if ( isnan( z[ i%z.length ] ) ) {
b.fail( 'should not return NaN' );
}
b.pass( 'benchmark finished' );
b.end();
}
}


// MAIN //

/**
* Main execution sequence.
*
* @private
*/
function main() {
var min;
var max;
var N;
var f;
var i;

min = 1; // 10^min
max = 6; // 10^max

for ( i = min; i <= max; i++ ) {
N = floor( pow( pow( 10, i ), 1.0/2.0 ) );
f = createBenchmark( N );
bench( pkg+'::native:size='+(N*N), opts, f );
}
}

main();
Loading