-
-
Notifications
You must be signed in to change notification settings - Fork 843
feat: add C implementation for stats/base/dists/binomial/cdf
#3897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
@stdlib/stats/base/dists/binomial/cdf
@stdlib/stats/base/dists/binomial/cdf
stats/base/dists/binomial/cdf
@AadishJ adding include |
Hey @Neerajpathak07 , I included the ternary as there was nothing made for a long long double previously so I made it for myself , is it incorrect and if so how should I do it correctly? |
Hey, @Neerajpathak07 I totally understand what you are saying but there are some important changes in those files as I have created the long long double version in them which did not exist before so removing those files would break my code, please let me know if I am thinking wrong or is there another way to do this. Thanks. |
@AadishJ Ok then, return betainc( p, x + 1.0, n - x, true, true ); return stdlib_base_betainc( p, x + 1.0, n - x, true, true ); but also you will be requiring |
That's completely fine. Thanks for the review |
/stdlib update-copyright-years |
Resolves #3448.
Description
This pull request:
Related Issues
This pull request:
@stdlib/stats/base/dists/binomial/cdf
#3448Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers