Skip to content

Commit 02b9077

Browse files
bench: refactor random number generation in stats/base/dists/chisquare
PR-URL: #4860 Reviewed-by: Athan Reines <kgryte@gmail.com>
1 parent 247af42 commit 02b9077

File tree

21 files changed

+250
-89
lines changed

21 files changed

+250
-89
lines changed

lib/node_modules/@stdlib/stats/base/dists/chisquare/cdf/benchmark/benchmark.js

Lines changed: 20 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,9 @@
2121
// MODULES //
2222

2323
var bench = require( '@stdlib/bench' );
24-
var ceil = require( '@stdlib/math/base/special/ceil' );
25-
var randu = require( '@stdlib/random/base/randu' );
24+
var Float64Array = require( '@stdlib/array/float64' );
25+
var uniform = require( '@stdlib/random/base/uniform' );
26+
var discreteUniform = require( '@stdlib/random/base/discrete-uniform' );
2627
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2728
var pkg = require( './../package.json' ).name;
2829
var cdf = require( './../lib' );
@@ -31,16 +32,23 @@ var cdf = require( './../lib' );
3132
// MAIN //
3233

3334
bench( pkg, function benchmark( b ) {
35+
var len;
3436
var k;
3537
var x;
3638
var y;
3739
var i;
3840

41+
len = 100;
42+
x = new Float64Array( len );
43+
k = new Float64Array( len );
44+
for ( i = 0; i < len; i++ ) {
45+
x[ i ] = uniform( 0.0, 100.0 );
46+
k[ i ] = discreteUniform( 1, 100 );
47+
}
48+
3949
b.tic();
4050
for ( i = 0; i < b.iterations; i++ ) {
41-
x = randu() * 100.0;
42-
k = ceil( randu()*100.0 );
43-
y = cdf( x, k );
51+
y = cdf( x[ i % len ], k[ i % len ] );
4452
if ( isnan( y ) ) {
4553
b.fail( 'should not return NaN' );
4654
}
@@ -55,18 +63,23 @@ bench( pkg, function benchmark( b ) {
5563

5664
bench( pkg+':factory', function benchmark( b ) {
5765
var mycdf;
66+
var len;
5867
var k;
5968
var x;
6069
var y;
6170
var i;
6271

6372
k = 10.0;
6473
mycdf = cdf.factory( k );
74+
len = 100;
75+
x = new Float64Array( len );
76+
for ( i = 0; i < len; i++ ) {
77+
x[ i ] = uniform( 0.0, 100.0 );
78+
}
6579

6680
b.tic();
6781
for ( i = 0; i < b.iterations; i++ ) {
68-
x = randu() * 100.0;
69-
y = mycdf( x );
82+
y = mycdf( x[ i % len ] );
7083
if ( isnan( y ) ) {
7184
b.fail( 'should not return NaN' );
7285
}

0 commit comments

Comments
 (0)