Skip to content

Commit 247af42

Browse files
bench: refactor random number generation in stats/base/dists/cosine
PR-URL: #4861 Reviewed-by: Athan Reines <kgryte@gmail.com>
1 parent 6d3a881 commit 247af42

File tree

24 files changed

+269
-122
lines changed

24 files changed

+269
-122
lines changed

lib/node_modules/@stdlib/stats/base/dists/cosine/cdf/benchmark/benchmark.js

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
var bench = require( '@stdlib/bench' );
2424
var Float64Array = require( '@stdlib/array/float64' );
25-
var randu = require( '@stdlib/random/base/randu' );
25+
var uniform = require( '@stdlib/random/base/uniform' );
2626
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2727
var EPS = require( '@stdlib/constants/float64/eps' );
2828
var pkg = require( './../package.json' ).name;
@@ -44,9 +44,9 @@ bench( pkg, function benchmark( b ) {
4444
mu = new Float64Array( len );
4545
s = new Float64Array( len );
4646
for ( i = 0; i < len; i++ ) {
47-
x[ i ] = ( randu()*100.0 ) - 50.0;
48-
mu[ i ] = ( randu()*20.0 ) - 10.0;
49-
s[ i ] = ( randu()*5.0 ) + EPS;
47+
x[ i ] = uniform( -50.0, 50.0 );
48+
mu[ i ] = uniform( -10.0, 10.0 );
49+
s[ i ] = uniform( EPS, 5.0 );
5050
}
5151

5252
b.tic();
@@ -66,6 +66,7 @@ bench( pkg, function benchmark( b ) {
6666

6767
bench( pkg+':factory', function benchmark( b ) {
6868
var mycdf;
69+
var len;
6970
var mu;
7071
var s;
7172
var x;
@@ -75,11 +76,15 @@ bench( pkg+':factory', function benchmark( b ) {
7576
mu = 10.0;
7677
s = 4.0;
7778
mycdf = cdf.factory( mu, s );
79+
len = 100;
80+
x = new Float64Array( len );
81+
for ( i = 0; i < len; i++ ) {
82+
x[ i ] = uniform( 0.0, 50.0 );
83+
}
7884

7985
b.tic();
8086
for ( i = 0; i < b.iterations; i++ ) {
81-
x = ( randu()*50.0 );
82-
y = mycdf( x );
87+
y = mycdf( x[ i % len ] );
8388
if ( isnan( y ) ) {
8489
b.fail( 'should not return NaN' );
8590
}

lib/node_modules/@stdlib/stats/base/dists/cosine/cdf/benchmark/benchmark.native.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
2525
var Float64Array = require( '@stdlib/array/float64' );
26-
var randu = require( '@stdlib/random/base/randu' );
26+
var uniform = require( '@stdlib/random/base/uniform' );
2727
var EPS = require( '@stdlib/constants/float64/eps' );
2828
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2929
var tryRequire = require( '@stdlib/utils/try-require' );
@@ -53,9 +53,9 @@ bench( pkg+'::native', opts, function benchmark( b ) {
5353
mu = new Float64Array( len );
5454
s = new Float64Array( len );
5555
for ( i = 0; i < len; i++ ) {
56-
x[ i ] = ( randu()*100.0 ) - 50.0;
57-
mu[ i ] = ( randu()*20.0 ) - 10.0;
58-
s[ i ] = ( randu()*5.0 ) + EPS;
56+
x[ i ] = uniform( -50.0, 50.0 );
57+
mu[ i ] = uniform( -10.0, 10.0 );
58+
s[ i ] = uniform( EPS, 5.0 );
5959
}
6060

6161
b.tic();

0 commit comments

Comments
 (0)