Name the default beacon node command better #7656
Merged
+8
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows running `nimbus_beacon_node beaconNode` to match `nimbus beaconNode`, keeping the names the same in the two binaries to ease future upgrade paths. Technically, if someone was using `nimbus_beacon_node noCommand` that would break with this change, but that's never been documented, nor does it appear in any `--help` or other sources of publically available functionality so no actual user impact is expected for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows running
nimbus_beacon_node beaconNodeto matchnimbus beaconNode, keeping the names the same in the two binaries to ease future upgrade paths.Technically, if someone was using
nimbus_beacon_node noCommandthat would break with this change, but that's never been documented, nor does it appear in any--helpor other sources of publically available functionality so no actual user impact is expected for now.