-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[@xstate/store] Skip events from undo/redo #5393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8328454
Add skipEvents option
davidkpiano 31db20d
Changeset
davidkpiano b70be7c
Update packages/xstate-store/src/undo.ts
davidkpiano c330ffc
Update packages/xstate-store/src/undo.ts
davidkpiano 5635250
Update packages/xstate-store/src/undo.ts
davidkpiano 98aaec2
Fix type issue
davidkpiano 312c9dc
Add snapshot to getTransactionId and skipEvent
davidkpiano b1a4115
Add changeset
davidkpiano 035942a
Merge branch 'main' into davidkpiano/store-skip
davidkpiano be2f559
Typo
davidkpiano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
--- | ||
'@xstate/store': minor | ||
--- | ||
|
||
Add `snapshot` parameter to `getTransactionId` function. | ||
|
||
```ts | ||
const store = createStore( | ||
undo( | ||
{ | ||
// ... | ||
}, | ||
{ | ||
getTransactionId: (event, snapshot) => | ||
snapshot.context.currentTransactionId | ||
} | ||
) | ||
); | ||
``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
--- | ||
'@xstate/store': minor | ||
--- | ||
|
||
Add `skipEvent` option to `undoRedo()` to exclude certain events from undo/redo history. | ||
|
||
```ts | ||
const store = createStore( | ||
undoRedo( | ||
{ | ||
context: { count: 0 }, | ||
on: { | ||
inc: (ctx) => ({ count: ctx.count + 1 }), | ||
log: (ctx) => ctx // No state change | ||
} | ||
}, | ||
{ | ||
skipEvent: (event, snapshot) => event.type === 'log' | ||
} | ||
) | ||
); | ||
``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: event actions API has order
ctx, event
whereas these two functions have the reverse order. They primarily work based on events which makes sense for event to be the first parameter but for consistency, we might want to consider unifying the order.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That'd be a breaking change