feat(vue): experimental scope dispose #5382
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR that attempts to move away from component life-cycle hooks in composables to effect scopes .
All tests are passing, with one caveat :
Now
nextTickneeds to be used when passing a callback touseActorRefthat access state that is not initialized.I feel like this is fine because this is kind of an odd pattern anyways.
Using
onMountedis more idiomatic to vue imo, and maybe we should change the test to :(Users should not be using useActorRef directly in most cases anyways, so its fine if the test doesn't use shallowRef)