-
-
Notifications
You must be signed in to change notification settings - Fork 571
[5.x] Add ability to specify the queue connection on static:warm command #8634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jasonvarga
merged 16 commits into
statamic:5.x
from
grantholle:static-warm-queue-connection
Jul 16, 2024
Merged
Changes from 8 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
8ef9dc8
Add ability to specify the queue connection on static:warm command
grantholle 018e898
Update description
grantholle 1a4af65
Fix code style
grantholle 51a3286
run 'em
jasonvarga 5c10b00
Add config option and additional command option for connection
grantholle 9a619e0
Merge branch 'static-warm-queue-connection' of github.com:grantholle/…
grantholle b062c96
Add and fix warm tests
grantholle 112a919
Merge branch '4.x' into pr/8634
duncanmcclean 06c7ff1
Merge branch '5.x' into pr/8634
duncanmcclean 9336646
Merge branch '5.x' into static-warm-queue-connection
jasonvarga 61c614c
these have failed since we switched to component output. using these …
jasonvarga 4aec8f2
nitpick
jasonvarga e9732c0
get rid of ability to specify connection. if you add the queue flag, …
jasonvarga f68da4f
prefix config with warm_ for consistency. add env var. group together.
jasonvarga c3646cb
include queue in test
jasonvarga 45b429f
wip
jasonvarga File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it might be worth changing this to
warm_queue_connection
to stay consistent withwarm_queue
above?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I wonder if it might be worth falling back to the default connection here so we don't need to do that in the
StaticWarm
command: