-
-
Notifications
You must be signed in to change notification settings - Fork 571
[6.x] Normalize and configure trailing slashes in URLs #11840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jesseleite
wants to merge
80
commits into
master
Choose a base branch
from
url-trailing-slashes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of a trailing slash 😅
…licate of `prependSiteUrl()`).
…rnal URLs more often.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Still wip, I want to test this with SEO Pro and SSG before we actually merge this.
This PR adds the ability to enforce trailing slashes in URLs via
URL::enforceTrailingSlashes()
, which has been asked for a fair bit.The idea is to make Statamic normalize trailing slashes in URLs (ie. remove them by default, or add them if the above is configured), while respecting URL query and fragment at the end of any given URL. To opt into this functionality for any URL output, simply wrap the URL with
URL::tidy($url)
.In fact, all methods on the
URL
facade should now return tidied output with normalized trailing slashes where relevant.For more advanced cases where an addon needs to control flow around enforcing/stripping trailing slashes, it can pass a
true
/false
bool intoURL::enforceTrailingSlashes($bool)
as necessary (see test coverage around this).References: statamic/ideas#1293
References: statamic/ssg#65
References: statamic/seo-pro#387