-
-
Notifications
You must be signed in to change notification settings - Fork 571
[5.x] Feature/add user profile form tabs sections #11836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AtmoFX
wants to merge
15
commits into
statamic:5.x
Choose a base branch
from
AtmoFX:feature/add-user-profile-form-tabs-sections
base: 5.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[5.x] Feature/add user profile form tabs sections #11836
AtmoFX
wants to merge
15
commits into
statamic:5.x
from
AtmoFX:feature/add-user-profile-form-tabs-sections
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edalzell
reviewed
Jun 3, 2025
edalzell
reviewed
Jun 3, 2025
edalzell
reviewed
Jun 3, 2025
edalzell
reviewed
Jun 3, 2025
edalzell
reviewed
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows a discussion on Discord.
It adds/changes the following to
{{ user:profile_form }}
:{{ sections }}
inner tag.This aligns the profile form to other forms where it was possible to loop over sections.
{{ tabs }}
inner tag.Tabs do not exist in forms' blueprints.
Technically, the tags work by:
getProfileTabs()
method:password
,password_confirmation
,roles
,groups
as well as assets fields, on the same principle as the existinggetProfileFields
method.getProfileFields
method.getProfileTab() is then used to create the new
{{ tabs }}` inner tag.{{ sections }}
inner tag.{{ fields }}
inner tag (i.e. instead of usinggetProfileFields()
to create{{ fields }}
).This removes duplicate code (
getProfileFields()
is not called anymore, though I have not removed it) and is expected to have better performance.Note: flattening the Array from
tabs
tosections
and then toprofile
is done on the same way as it is done for regular forms:But it could have been done using:
One method might be superior in terms of performance.