[5.x] Clone internal data collections #11777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yaaas, I had to work around this in my Events addon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The classes that use
ContainsDataandContainsSupplementalDatastore their data as collection objects not plain arrays. Because of this when you clone an entry object the clone still points to the samedatacollection object, so if you set something on the clone it also gets set on the original (same for supplemental data).This PR fixes that by cloning the internal data collections when the main objects are cloned.
It also clones the user group
roles, and the localised termterm(as that's required to clone the termdata).It also adds a couple of missing
$this->supplements = collect();constructor lines.