-
-
Notifications
You must be signed in to change notification settings - Fork 571
[6.x] Replace underscore with lodash #11529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove global _ helper. Use imports everywhere. Most things are the same method. Replaced where necessary. Replaced with native JS in some places.
# Conflicts: # resources/js/components/inputs/relationship/Selector.vue # resources/js/components/navigation/View.vue
Underscore's clone() was a shallow clone
jasonvarga
added a commit
that referenced
this pull request
Mar 21, 2025
This was really just because this.field should have been this.fields - typo introduced in #11529. But, before I realized that, I simplified to native JS thinking that was part of it. Nope. But keeping the native JS is nice to get rid of a couple of lodash imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
_
helper and uses ES imports to improve bundle size*.* Ironically, using lodash is a little heavier, but at least it's more modern. We may replace more bits with native JS in the future that will decrease bundle size further.
The removal of the
_
helper is a breaking change and means addons will have to import lodash themselves.However you may be able to just use native JS for most things anyway now. (And probably should.)