Skip to content

[5.x] Fix some RTL issues #10029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 10, 2024
Merged

[5.x] Fix some RTL issues #10029

merged 8 commits into from
May 10, 2024

Conversation

peimn
Copy link
Contributor

@peimn peimn commented May 9, 2024

  • force direction to the left where necessary
  • set default direction to ltr in get function
  • set arrow direction in rtl

@duncanmcclean duncanmcclean changed the title [5.x] fix some rtl issues [5.x] Fix some rtl issues May 10, 2024
@duncanmcclean duncanmcclean changed the title [5.x] Fix some rtl issues [5.x] Fix some RTL issues May 10, 2024
…to text fieldtype ...

The css rules were targeting the "Sites" form.
The rules only worked when you had multisite enabled and the fields are nested in a grid. If you had a single site, the fields would be top level and wouldn't get the css applied.

Simplify it by just forcing it ltr at the field level.
@jasonvarga jasonvarga merged commit 807da35 into statamic:5.x May 10, 2024
16 checks passed
@peimn peimn deleted the fix/rtl branch May 10, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants