[4.x] Add Vary: X-Requested-With header to CP responses
#10016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran into this issue a couple of times when navigating back to the entries listing too. Just a quick note. I never bothered raising an issue and don't know when I last saw it. Might be fixed by now. |
Oh weird, I've never ran into it with the entries listing. Hopefully this PR fixes it for you anyway. If it hasn't, feel free to open an issue and we can take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a
Vary: X-Requested-Withheader to Control Panel responses.This fixes an issue with the Users listing page on Chrome. If you go onto the users listing table, do any kind of filtering, click on a user, then use the browser back button, you'll see a JSON response instead of the listing page.
This was only happening on the Users listing because it's the Blade view & JSON responses share the same URL, where our other listing pages have separate URLs.
From what I can tell, I believe this issue is only affecting Chrome(ium). The
Varyheader seems to tell the browser which headers cause a different response to be returned - theX-Requested-Withheader is different between the two types of requests so it fixes the issue.Fixes #9937.