Remove the IsFirst columns in all components used in Blake example #1067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Blake example can run with LOG_N_INSTANCES=6 but not other parameters, because the Scheduler, Round, and XOR table components may want to use IsFirst columns of the same size, but the framework prevents duplicated preprocessed columns, which consistently happens when LOG_N_INSTANCES is larger than 6.
This PR changes the existing example to reflect the recent changes to logUp sum by removing the use of IsFirst columns altogether across all components. Note that such removal is safe since these columns have already been "unused" by the proof system.