Skip to content

FromBasefield to EF #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

FromBasefield to EF #1015

wants to merge 1 commit into from

Conversation

shaharsamocha7
Copy link
Collaborator

Add from basefield to constraint framework EF

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 92.80%. Comparing base (dad3688) to head (5232768).

Files with missing lines Patch % Lines
crates/prover/src/constraint_framework/info.rs 0.00% 3 Missing ⚠️
crates/prover/src/core/backend/simd/m31.rs 0.00% 3 Missing ⚠️
...es/prover/src/core/backend/simd/very_packed_m31.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1015      +/-   ##
==========================================
- Coverage   92.86%   92.80%   -0.06%     
==========================================
  Files         105      105              
  Lines       14259    14268       +9     
  Branches    14259    14268       +9     
==========================================
  Hits        13241    13241              
- Misses        938      947       +9     
  Partials       80       80              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Gali-StarkWare Gali-StarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants