Skip to content

chore: add logs #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore: add logs #321

wants to merge 1 commit into from

Conversation

amosStarkware
Copy link
Contributor

@amosStarkware amosStarkware commented Jul 17, 2024

This change is Reviewable

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 70.06%. Comparing base (ff1d8ca) to head (a3d1f50).

Files Patch % Lines
crates/committer/src/block_committer/commit.rs 0.00% 6 Missing ⚠️
crates/committer_cli/src/commands.rs 0.00% 6 Missing ⚠️
crates/committer_cli/src/main.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           amos/use_tracing     #321      +/-   ##
====================================================
- Coverage             70.56%   70.06%   -0.51%     
====================================================
  Files                    39       39              
  Lines                  2096     2111      +15     
  Branches               2096     2111      +15     
====================================================
  Hits                   1479     1479              
- Misses                  547      562      +15     
  Partials                 70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware)


crates/committer_cli/src/commands.rs line 15 at r1 (raw file):

    let input = parse_input(input_string).expect("Failed to parse the given input.");
    info!(
        "Parsed commiter input successfully. Original Contracts Trie Root Hash: {:?}, 

typo

Suggestion:

committer

@amosStarkware amosStarkware deleted the branch amos/use_tracing August 6, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants