Skip to content

refactor: use mock leaf in create tree test #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AvivYossef-starkware
Copy link
Collaborator

@AvivYossef-starkware AvivYossef-starkware commented Jul 17, 2024

This change is Reviewable

Copy link
Collaborator Author

AvivYossef-starkware commented Jul 17, 2024

@AvivYossef-starkware AvivYossef-starkware marked this pull request as ready for review July 17, 2024 09:48
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.31%. Comparing base (8281710) to head (f8fbe2f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
- Coverage   70.45%   70.31%   -0.15%     
==========================================
  Files          38       38              
  Lines        2109     2109              
  Branches     2109     2109              
==========================================
- Hits         1486     1483       -3     
- Misses        553      556       +3     
  Partials       70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.362 ms 34.400 ms 34.441 ms]
change: [-4.8167% -3.1926% -1.7541%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mild

full_committer_flow performance improved 😺
full_committer_flow time: [29.066 ms 29.113 ms 29.162 ms]
change: [-1.7761% -1.5311% -1.2926%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mild

@AvivYossef-starkware AvivYossef-starkware force-pushed the 07-17-refactor_use_mock_leaf_in_create_tree_test branch from c7fe4b1 to fbdf828 Compare July 17, 2024 10:40
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [33.507 ms 33.540 ms 33.579 ms]
change: [-4.2740% -2.6295% -1.1471%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
4 (4.00%) high mild
3 (3.00%) high severe

@AvivYossef-starkware AvivYossef-starkware force-pushed the 07-17-refactor_use_mock_leaf_in_create_tree_test branch from fbdf828 to 6f115fe Compare July 17, 2024 11:05
@AvivYossef-starkware AvivYossef-starkware changed the base branch from aviv/impl_mock_leaf to aviv/create_mock_test_leaf July 17, 2024 11:05
@AvivYossef-starkware AvivYossef-starkware changed the base branch from aviv/create_mock_test_leaf to aviv/impl_mock_leaf July 17, 2024 11:05
@AvivYossef-starkware AvivYossef-starkware force-pushed the 07-17-refactor_use_mock_leaf_in_create_tree_test branch from 6f115fe to 102c92d Compare July 17, 2024 11:26
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware)


crates/committer/src/patricia_merkle_tree/original_skeleton_tree/create_tree_test.rs line 206 at r1 (raw file):

    #[values(true, false)] compare_modified_leaves: bool,
) {
    use crate::patricia_merkle_tree::internal_test_utils::OriginalSkeletonMockTrieConfig;

move to top of file

Code quote:

use crate::patricia_merkle_tree::internal_test_utils::OriginalSkeletonMockTrieConfig;

crates/committer/src/patricia_merkle_tree/original_skeleton_tree/create_tree_test.rs line 430 at r1 (raw file):

    (leaf.get_db_key(&leaf.0.to_bytes_be()), leaf.serialize())
}
pub(crate) fn create_compiled_class_leaf_entry(val: u128) -> (StorageKey, StorageValue) {

restore the newline

Code quote:

}
pub(crate) fn create_compiled_class_leaf_entry(val: u128) -> (StorageKey, StorageValue) {

@AvivYossef-starkware AvivYossef-starkware force-pushed the 07-17-refactor_use_mock_leaf_in_create_tree_test branch from 102c92d to 1b3c352 Compare July 17, 2024 14:47
@AvivYossef-starkware AvivYossef-starkware force-pushed the 07-17-refactor_use_mock_leaf_in_create_tree_test branch from 1b3c352 to f8fbe2f Compare July 22, 2024 07:06
@AvivYossef-starkware AvivYossef-starkware changed the base branch from aviv/impl_mock_leaf to main July 22, 2024 07:06
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [33.885 ms 33.915 ms 33.947 ms]
change: [-4.9040% -3.3748% -2.0413%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
1 (1.00%) low mild
3 (3.00%) high mild
1 (1.00%) high severe

Copy link
Collaborator Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 22 files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware)


crates/committer/src/patricia_merkle_tree/original_skeleton_tree/create_tree_test.rs line 206 at r1 (raw file):

Previously, dorimedini-starkware wrote…

move to top of file

Done.


crates/committer/src/patricia_merkle_tree/original_skeleton_tree/create_tree_test.rs line 430 at r1 (raw file):

Previously, dorimedini-starkware wrote…

restore the newline

Done.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 22 files at r2, 21 of 21 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

@AvivYossef-starkware AvivYossef-starkware added this pull request to the merge queue Jul 22, 2024
Merged via the queue into main with commit 21358aa Jul 22, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants