-
Notifications
You must be signed in to change notification settings - Fork 0
chore: switched to tracing crate #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #302 +/- ##
==========================================
- Coverage 70.59% 70.56% -0.04%
==========================================
Files 38 39 +1
Lines 2095 2096 +1
Branches 2095 2096 +1
==========================================
Hits 1479 1479
- Misses 546 547 +1
Partials 70 70 ☔ View full report in Codecov by Sentry. |
a0d733b
to
b0522b1
Compare
Benchmark movements: |
65be1b5
to
b68459a
Compare
Benchmark movements: |
4aa8f8b
to
d376383
Compare
d376383
to
fd347b1
Compare
fd347b1
to
ff1d8ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do the three percentages represent?
Python side:
https://reviewable.io/reviews/starkware-industries/starkware/35564
Reviewable status: 0 of 10 files reviewed, all discussions resolved (waiting on @amosStarkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 10 files reviewed, 1 unresolved discussion (waiting on @amosStarkware)
crates/committer_cli/src/tracing_utils.rs
line 10 at r1 (raw file):
.with_line_number(true) .init(); }
Papyrus tracing configuration for reference (Mempool is the same, I think):
https://github.com/starkware-libs/papyrus/blob/6e59018353cc66e5f1c299481be2354c981a58ec/crates/papyrus_node/src/main.rs#L402-L410
should I copy paste?
Code quote:
pub fn configure_tracing() {
fmt()
.with_ansi(false)
.with_target(false)
.with_file(true)
.with_line_number(true)
.init();
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 10 files reviewed, 1 unresolved discussion (waiting on @amosStarkware)
crates/committer_cli/src/tracing_utils.rs
line 10 at r1 (raw file):
Previously, amosStarkware wrote…
Papyrus tracing configuration for reference (Mempool is the same, I think):
https://github.com/starkware-libs/papyrus/blob/6e59018353cc66e5f1c299481be2354c981a58ec/crates/papyrus_node/src/main.rs#L402-L410should I copy paste?
(this does not change where error logs are printed to)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @amosStarkware)
crates/committer_cli/src/main.rs
line 61 at r1 (raw file):
async fn main() { // Initialize the logger configure_tracing();
how do you set the log level here?
you are conflicting with this
Code quote:
configure_tracing();
crates/committer_cli/src/tracing_utils.rs
line 10 at r1 (raw file):
Previously, amosStarkware wrote…
(this does not change where error logs are printed to)
please add a TODO to move this - and other tracing instantiations in the monorepo - to a common location
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
crates/committer_cli/src/main.rs
line 61 at r1 (raw file):
Previously, dorimedini-starkware wrote…
how do you set the log level here?
you are conflicting with this
Done in sequencer PR
https://reviewable.io/reviews/starkware-libs/sequencer/291
crates/committer_cli/src/tracing_utils.rs
line 10 at r1 (raw file):
Previously, dorimedini-starkware wrote…
please add a TODO to move this - and other tracing instantiations in the monorepo - to a common location
Done in sequencer PR
https://reviewable.io/reviews/starkware-libs/sequencer/291
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware)
a discussion (no related file):
please close this PR
This change is