Skip to content

chore: switched to tracing crate #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

amosStarkware
Copy link
Contributor

@amosStarkware amosStarkware commented Jul 11, 2024

This change is Reviewable

@amosStarkware amosStarkware self-assigned this Jul 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 70.56%. Comparing base (1d383c5) to head (ff1d8ca).

Files Patch % Lines
crates/committer_cli/src/tracing_utils.rs 0.00% 8 Missing ⚠️
crates/committer_cli/src/main.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #302      +/-   ##
==========================================
- Coverage   70.59%   70.56%   -0.04%     
==========================================
  Files          38       39       +1     
  Lines        2095     2096       +1     
  Branches     2095     2096       +1     
==========================================
  Hits         1479     1479              
- Misses        546      547       +1     
  Partials       70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amosStarkware amosStarkware force-pushed the amos/use_tracing branch 2 times, most recently from a0d733b to b0522b1 Compare July 14, 2024 14:25
Copy link

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.308 ms 34.766 ms 35.323 ms]
change: [+1.4313% +2.8670% +4.4954%] (p = 0.00 < 0.05)
Performance has regressed.
Found 13 outliers among 100 measurements (13.00%)
4 (4.00%) high mild
9 (9.00%) high severe

@amosStarkware amosStarkware force-pushed the amos/use_tracing branch 2 times, most recently from 65be1b5 to b68459a Compare July 14, 2024 15:46
Copy link

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.439 ms 34.897 ms 35.451 ms]
change: [+1.3999% +2.6935% +4.1684%] (p = 0.00 < 0.05)
Performance has regressed.
Found 10 outliers among 100 measurements (10.00%)
3 (3.00%) high mild
7 (7.00%) high severe

@amosStarkware amosStarkware force-pushed the amos/use_tracing branch 5 times, most recently from 4aa8f8b to d376383 Compare July 17, 2024 10:51
@amosStarkware amosStarkware changed the title Amos/use tracing chore: switched to tracing crate Jul 17, 2024
Copy link
Contributor Author

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do the three percentages represent?
Python side:
https://reviewable.io/reviews/starkware-industries/starkware/35564

Reviewable status: 0 of 10 files reviewed, all discussions resolved (waiting on @amosStarkware)

Copy link
Contributor Author

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 10 files reviewed, 1 unresolved discussion (waiting on @amosStarkware)


crates/committer_cli/src/tracing_utils.rs line 10 at r1 (raw file):

        .with_line_number(true)
        .init();
}

Papyrus tracing configuration for reference (Mempool is the same, I think):
https://github.com/starkware-libs/papyrus/blob/6e59018353cc66e5f1c299481be2354c981a58ec/crates/papyrus_node/src/main.rs#L402-L410

should I copy paste?

Code quote:

pub fn configure_tracing() {
    fmt()
        .with_ansi(false)
        .with_target(false)
        .with_file(true)
        .with_line_number(true)
        .init();
}

Copy link
Contributor Author

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 10 files reviewed, 1 unresolved discussion (waiting on @amosStarkware)


crates/committer_cli/src/tracing_utils.rs line 10 at r1 (raw file):

Previously, amosStarkware wrote…

Papyrus tracing configuration for reference (Mempool is the same, I think):
https://github.com/starkware-libs/papyrus/blob/6e59018353cc66e5f1c299481be2354c981a58ec/crates/papyrus_node/src/main.rs#L402-L410

should I copy paste?

(this does not change where error logs are printed to)

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @amosStarkware)


crates/committer_cli/src/main.rs line 61 at r1 (raw file):

async fn main() {
    // Initialize the logger
    configure_tracing();

how do you set the log level here?
you are conflicting with this

Code quote:

configure_tracing();

crates/committer_cli/src/tracing_utils.rs line 10 at r1 (raw file):

Previously, amosStarkware wrote…

(this does not change where error logs are printed to)

please add a TODO to move this - and other tracing instantiations in the monorepo - to a common location

Copy link
Contributor Author

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)


crates/committer_cli/src/main.rs line 61 at r1 (raw file):

Previously, dorimedini-starkware wrote…

how do you set the log level here?
you are conflicting with this

Done in sequencer PR
https://reviewable.io/reviews/starkware-libs/sequencer/291


crates/committer_cli/src/tracing_utils.rs line 10 at r1 (raw file):

Previously, dorimedini-starkware wrote…

please add a TODO to move this - and other tracing instantiations in the monorepo - to a common location

Done in sequencer PR
https://reviewable.io/reviews/starkware-libs/sequencer/291

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware)

a discussion (no related file):
please close this PR


@amosStarkware amosStarkware deleted the amos/use_tracing branch August 6, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants