Skip to content

build: impl debug for felt #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

AvivYossef-starkware
Copy link
Collaborator

@AvivYossef-starkware AvivYossef-starkware commented Jun 5, 2024

This change is Reviewable

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)


crates/committer/src/patricia_merkle_tree/types_test.rs line 147 at r1 (raw file):

#[rstest]
fn test_felt_printing() {
    assert_eq!(format!("{:?}", Felt::TWO), "2");

add a case so it's clear that the number isn't printed in hex format

Suggestion:

assert_eq!(format!("{:?}", Felt::TWO), "2");
assert_eq!(format!("{:?}", felt!(17_u8), "17");

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/build_print_for_felt branch from 1cabdd6 to 22bbe89 Compare June 5, 2024 17:18
@AvivYossef-starkware AvivYossef-starkware changed the base branch from aviv/refactor_testing to main June 5, 2024 17:19
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.31%. Comparing base (83a3e89) to head (e68bbbe).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
+ Coverage   62.24%   62.31%   +0.07%     
==========================================
  Files          36       36              
  Lines        1613     1616       +3     
  Branches     1613     1616       +3     
==========================================
+ Hits         1004     1007       +3     
  Misses        558      558              
  Partials       51       51              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/build_print_for_felt branch from 22bbe89 to bafaedb Compare June 5, 2024 17:20
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/build_print_for_felt branch from bafaedb to e68bbbe Compare June 5, 2024 17:22
Copy link
Collaborator Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)


crates/committer/src/patricia_merkle_tree/types_test.rs line 147 at r1 (raw file):

Previously, dorimedini-starkware wrote…

add a case so it's clear that the number isn't printed in hex format

Done.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 3 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

@AvivYossef-starkware AvivYossef-starkware added this pull request to the merge queue Jun 6, 2024
Merged via the queue into main with commit 618afae Jun 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants