-
Notifications
You must be signed in to change notification settings - Fork 0
build: impl debug for felt #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)
crates/committer/src/patricia_merkle_tree/types_test.rs
line 147 at r1 (raw file):
#[rstest] fn test_felt_printing() { assert_eq!(format!("{:?}", Felt::TWO), "2");
add a case so it's clear that the number isn't printed in hex format
Suggestion:
assert_eq!(format!("{:?}", Felt::TWO), "2");
assert_eq!(format!("{:?}", felt!(17_u8), "17");
1cabdd6
to
22bbe89
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #198 +/- ##
==========================================
+ Coverage 62.24% 62.31% +0.07%
==========================================
Files 36 36
Lines 1613 1616 +3
Branches 1613 1616 +3
==========================================
+ Hits 1004 1007 +3
Misses 558 558
Partials 51 51 ☔ View full report in Codecov by Sentry. |
22bbe89
to
bafaedb
Compare
bafaedb
to
e68bbbe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
crates/committer/src/patricia_merkle_tree/types_test.rs
line 147 at r1 (raw file):
Previously, dorimedini-starkware wrote…
add a case so it's clear that the number isn't printed in hex format
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)
This change is