refactor: rename TreeHeight => SubTreeHeight and TreeHeight::MAX => TreeHeight::ACTUAL_HEIGHT #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## nimrod/tree_height/remove_tree_height_from_updated_tree #192 +/- ##
========================================================================================
Coverage 61.47% 61.47%
========================================================================================
Files 36 36
Lines 1612 1612
Branches 1612 1612
========================================================================================
Hits 991 991
Misses 571 571
Partials 50 50 ☔ View full report in Codecov by Sentry. |
nimrod-starkware
force-pushed
the
nimrod/tree_height/remove_tree_height_from_updated_tree
branch
2 times, most recently
from
6aab617 to
482b2f5
Compare
dorimedini-starkware
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)
Base automatically changed from
nimrod/tree_height/remove_tree_height_from_updated_tree
to
main
June 4, 2024 07:42
…reeHeight::ACTUAL_HEIGHT
nimrod-starkware
force-pushed
the
nimrod/tree_height/define_height_as_constant
branch
from
9367185 to
4f8e3dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is