-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: remove tree height field from updated skeleton tree #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove tree height field from updated skeleton tree #191
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #191 +/- ##
==========================================
- Coverage 61.61% 61.47% -0.15%
==========================================
Files 36 36
Lines 1618 1612 -6
Branches 1618 1612 -6
==========================================
- Hits 997 991 -6
Misses 571 571
Partials 50 50 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)
crates/committer/src/patricia_merkle_tree/updated_skeleton_tree/tree.rs
line 41 at r1 (raw file):
pub(crate) struct UpdatedSkeletonTreeImpl { pub(crate) skeleton_tree: UpdatedSkeletonNodeMap, }
Suggestion:
// TODO(Dori, 1/7/2024): Make this a tuple struct.
pub(crate) struct UpdatedSkeletonTreeImpl {
pub(crate) skeleton_tree: UpdatedSkeletonNodeMap,
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
crates/committer/src/patricia_merkle_tree/updated_skeleton_tree/tree.rs
line 41 at r1 (raw file):
pub(crate) struct UpdatedSkeletonTreeImpl { pub(crate) skeleton_tree: UpdatedSkeletonNodeMap, }
Done.
Should i also add a todo to struct OriginalSkeletonTreeImpl
?
it also has only one field.
fcb1bf0
to
6aab617
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)
crates/committer/src/patricia_merkle_tree/updated_skeleton_tree/tree.rs
line 41 at r1 (raw file):
Previously, nimrod-starkware wrote…
Done.
Should i also add a todo tostruct OriginalSkeletonTreeImpl
?
it also has only one field.
yes please
6aab617
to
482b2f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
crates/committer/src/patricia_merkle_tree/updated_skeleton_tree/tree.rs
line 41 at r1 (raw file):
Previously, dorimedini-starkware wrote…
yes please
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)
This change is