Skip to content

refactor: remove tree height field from updated skeleton tree #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nimrod-starkware
Copy link
Contributor

@nimrod-starkware nimrod-starkware commented Jun 4, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.47%. Comparing base (b12c761) to head (482b2f5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
- Coverage   61.61%   61.47%   -0.15%     
==========================================
  Files          36       36              
  Lines        1618     1612       -6     
  Branches     1618     1612       -6     
==========================================
- Hits          997      991       -6     
  Misses        571      571              
  Partials       50       50              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)


crates/committer/src/patricia_merkle_tree/updated_skeleton_tree/tree.rs line 41 at r1 (raw file):

pub(crate) struct UpdatedSkeletonTreeImpl {
    pub(crate) skeleton_tree: UpdatedSkeletonNodeMap,
}

Suggestion:

// TODO(Dori, 1/7/2024): Make this a tuple struct.
pub(crate) struct UpdatedSkeletonTreeImpl {
    pub(crate) skeleton_tree: UpdatedSkeletonNodeMap,
}

Copy link
Contributor Author

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)


crates/committer/src/patricia_merkle_tree/updated_skeleton_tree/tree.rs line 41 at r1 (raw file):

pub(crate) struct UpdatedSkeletonTreeImpl {
    pub(crate) skeleton_tree: UpdatedSkeletonNodeMap,
}

Done.
Should i also add a todo to struct OriginalSkeletonTreeImpl?
it also has only one field.

@nimrod-starkware nimrod-starkware force-pushed the nimrod/tree_height/remove_tree_height_from_updated_tree branch from fcb1bf0 to 6aab617 Compare June 4, 2024 07:31
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)


crates/committer/src/patricia_merkle_tree/updated_skeleton_tree/tree.rs line 41 at r1 (raw file):

Previously, nimrod-starkware wrote…

Done.
Should i also add a todo to struct OriginalSkeletonTreeImpl?
it also has only one field.

yes please

@nimrod-starkware nimrod-starkware force-pushed the nimrod/tree_height/remove_tree_height_from_updated_tree branch from 6aab617 to 482b2f5 Compare June 4, 2024 07:38
Copy link
Contributor Author

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)


crates/committer/src/patricia_merkle_tree/updated_skeleton_tree/tree.rs line 41 at r1 (raw file):

Previously, dorimedini-starkware wrote…

yes please

Done.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

@nimrod-starkware nimrod-starkware added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit 6b29993 Jun 4, 2024
12 checks passed
@nimrod-starkware nimrod-starkware deleted the nimrod/tree_height/remove_tree_height_from_updated_tree branch June 4, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants