-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: removed the tree height parameter to rust and added a regression test #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #189 +/- ##
==========================================
+ Coverage 62.06% 62.67% +0.60%
==========================================
Files 36 36
Lines 1629 1677 +48
Branches 1629 1677 +48
==========================================
+ Hits 1011 1051 +40
- Misses 568 574 +6
- Partials 50 52 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion
a discussion (no related file):
python side PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)
crates/committer_cli/src/tests/python_tests.rs
line 155 at r1 (raw file):
fn get_tree_height() -> String { format!("{}", u8::from(TreeHeight::MAX)) }
wouldn't it be better to add derive_more::Display
in the #[derive]
attribute of TreeHeight
? then you could do something like this
Suggestion:
fn get_tree_height() -> String {
TreeHeight::MAX.into()
}
b6d60ef
to
32e1fcd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 5 of 7 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
crates/committer_cli/src/tests/python_tests.rs
line 155 at r1 (raw file):
Previously, dorimedini-starkware wrote…
wouldn't it be better to add
derive_more::Display
in the#[derive]
attribute ofTreeHeight
? then you could do something like this
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)
…ssion test
This change is