Skip to content

refactor: removed the tree height parameter to rust and added a regression test #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

nimrod-starkware
Copy link
Contributor

@nimrod-starkware nimrod-starkware commented Jun 3, 2024

…ssion test


This change is Reviewable

@nimrod-starkware nimrod-starkware self-assigned this Jun 3, 2024
@nimrod-starkware nimrod-starkware changed the title refactor: removed the tree height parameter to rust and added a regre… refactor: removed the tree height parameter to rust and added a regression test Jun 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 62.67%. Comparing base (5ca884e) to head (32e1fcd).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/committer/src/patricia_merkle_tree/types.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
+ Coverage   62.06%   62.67%   +0.60%     
==========================================
  Files          36       36              
  Lines        1629     1677      +48     
  Branches     1629     1677      +48     
==========================================
+ Hits         1011     1051      +40     
- Misses        568      574       +6     
- Partials       50       52       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion

a discussion (no related file):
python side PR


Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)


crates/committer_cli/src/tests/python_tests.rs line 155 at r1 (raw file):

fn get_tree_height() -> String {
    format!("{}", u8::from(TreeHeight::MAX))
}

wouldn't it be better to add derive_more::Display in the #[derive] attribute of TreeHeight? then you could do something like this

Suggestion:

fn get_tree_height() -> String {
    TreeHeight::MAX.into()
}

@nimrod-starkware nimrod-starkware force-pushed the nimrod/tree_height/input_from_python branch from b6d60ef to 32e1fcd Compare June 3, 2024 13:56
Copy link
Contributor Author

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 5 of 7 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)


crates/committer_cli/src/tests/python_tests.rs line 155 at r1 (raw file):

Previously, dorimedini-starkware wrote…

wouldn't it be better to add derive_more::Display in the #[derive] attribute of TreeHeight? then you could do something like this

Done.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

@nimrod-starkware nimrod-starkware added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit 027c5b4 Jun 3, 2024
12 checks passed
@nimrod-starkware nimrod-starkware deleted the nimrod/tree_height/input_from_python branch June 3, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants