fix: wrong handling of insert return value

[nimrod-starkware]

This change is 

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 62.17%. Comparing base (303f6d7) to head (80c0090).
Report is 1 commits behind head on main.

Files	Patch %	Lines
...patricia_merkle_tree/updated_skeleton_tree/tree.rs	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
+ Coverage   62.13%   62.17%   +0.03%     
==========================================
  Files          36       36              
  Lines        1624     1631       +7     
  Branches     1624     1631       +7     
==========================================
+ Hits         1009     1014       +5     
- Misses        565      567       +2     
  Partials       50       50              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[TzahiTaub]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)

---

crates/committer/src/patricia_merkle_tree/updated_skeleton_tree/tree.rs line 76 at r1 (raw file):

                };

                let _ = updated_skeleton_tree

No need

[TzahiTaub]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)

---

crates/committer/src/patricia_merkle_tree/updated_skeleton_tree/tree.rs line 79 at r1 (raw file):

                    .skeleton_tree
                    .insert(NodeIndex::ROOT, new_node)
                    .map(|_| panic!("Root node already exists in the updated skeleton tree"));

WDYT on this?

Suggestion:

updated_skeleton_tree
    .skeleton_tree
    .insert(NodeIndex::ROOT, new_node)
    .map_or((), |_| {
        unreachable!("Root node already exists in the updated skeleton tree")
    })

[TzahiTaub]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)

---

crates/committer/src/patricia_merkle_tree/updated_skeleton_tree/tree.rs line 79 at r1 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

WDYT on this?

panic instead of unreachable

[nimrod-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

---

crates/committer/src/patricia_merkle_tree/updated_skeleton_tree/tree.rs line 79 at r1 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

panic instead of unreachable

done

[TzahiTaub]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)