fix: fetch nodes didn't support empty tree

[nimrod-starkware]

This change is 

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 62.06%. Comparing base (303f6d7) to head (414d370).

Files	Patch %	Lines
..._merkle_tree/original_skeleton_tree/create_tree.rs	40.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
- Coverage   62.13%   62.06%   -0.07%     
==========================================
  Files          36       36              
  Lines        1624     1629       +5     
  Branches     1624     1629       +5     
==========================================
+ Hits         1009     1011       +2     
- Misses        565      568       +3     
  Partials       50       50              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dorimedini-starkware]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware and @TzahiTaub)

---

crates/committer/src/hash/hash_trait.rs line 9 at r1 (raw file):

    #[allow(dead_code)]
    pub(crate) const ZERO: HashOutput = HashOutput(Felt::ZERO);
    pub(crate) const EMPTY_NODE: HashOutput = Self::ZERO;

please rename for clarity - for example, an "empty ContractState" (which is a leaf node with three zeros as data) will not have a hash that is equal to zero

Suggestion:

pub(crate) const ROOT_OF_EMPTY_TREE: HashOutput = Self::ZERO;

[nimrod-starkware]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @TzahiTaub)

---

crates/committer/src/hash/hash_trait.rs line 9 at r1 (raw file):

Previously, dorimedini-starkware wrote…

please rename for clarity - for example, an "empty ContractState" (which is a leaf node with three zeros as data) will not have a hash that is equal to zero

Done.

[dorimedini-starkware]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)