-
Notifications
You must be signed in to change notification settings - Fork 0
feat: toml formatting verification in CI #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2ad1967
to
e940fae
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
==========================================
+ Coverage 62.11% 63.07% +0.96%
==========================================
Files 36 36
Lines 1668 1717 +49
Branches 1668 1717 +49
==========================================
+ Hits 1036 1083 +47
- Misses 583 586 +3
+ Partials 49 48 -1 ☔ View full report in Codecov by Sentry. |
7241d7d
to
771f27f
Compare
Signed-off-by: Dori Medini <dori@starkware.co>
771f27f
to
db2a60c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
.github/workflows/ci.yml
line 72 at r2 (raw file):
crate: taplo-cli version: '0.9.0' locked: true
Do the different uses/with
ordering compared to clippy (for example) have any meaning?
Code quote:
- uses: Swatinem/rust-cache@v2
- uses: baptiste0928/cargo-install@v3
with:
crate: taplo-cli
version: '0.9.0'
locked: true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
.github/workflows/ci.yml
line 72 at r2 (raw file):
Previously, TzahiTaub (Tzahi) wrote…
Do the different
uses/with
ordering compared to clippy (for example) have any meaning?
Order matters, but I think the order between Swatinem/rust-cache
and baptiste0928/cargo-install
doesn't matter.
I am not even sure Swatinem/rust-cache
is needed, but in case it caches something I think it doesn't hurt (the phase is really fast).
Also, the order here is the same as clippy, except the dtolnay/rust-toolchain
here doesn't need the clippy
component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
This change is