-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: remove the tree_height field inside original skleton tree #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove the tree_height field inside original skleton tree #180
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
==========================================
- Coverage 62.22% 61.69% -0.53%
==========================================
Files 36 36
Lines 1673 1650 -23
Branches 1673 1650 -23
==========================================
- Hits 1041 1018 -23
Misses 583 583
Partials 49 49 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware and @TzahiTaub)
crates/committer/src/patricia_merkle_tree/original_skeleton_tree/create_tree.rs
line 201 at r1 (raw file):
/// 'Plants' the given smaller tree at the lowest leftmost node in order to create a tree of /// height TREE_HEIGHT::MAX. pub(crate) fn create_actual_sized_tree_from_smaller_tree(
this function still isn't used here, correct? please remove it (see comment in previous PR)
Code quote:
create_actual_sized_tree_from_smaller_tree
d92462d
to
0e1bf97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @TzahiTaub)
crates/committer/src/patricia_merkle_tree/original_skeleton_tree/create_tree.rs
line 201 at r1 (raw file):
Previously, dorimedini-starkware wrote…
this function still isn't used here, correct? please remove it (see comment in previous PR)
removed it
416fb4d
to
b4cc3f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)
b5e5968
to
7a3df56
Compare
f4bfe97
to
9711ca8
Compare
9711ca8
to
7c92538
Compare
7c92538
to
93998ed
Compare
This change is