Skip to content

refactor: remove the tree_height field inside original skleton tree #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nimrod-starkware
Copy link
Contributor

@nimrod-starkware nimrod-starkware commented Jun 2, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 61.69%. Comparing base (82c9f98) to head (93998ed).

Files Patch % Lines
..._merkle_tree/original_skeleton_tree/create_tree.rs 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
- Coverage   62.22%   61.69%   -0.53%     
==========================================
  Files          36       36              
  Lines        1673     1650      -23     
  Branches     1673     1650      -23     
==========================================
- Hits         1041     1018      -23     
  Misses        583      583              
  Partials       49       49              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware and @TzahiTaub)


crates/committer/src/patricia_merkle_tree/original_skeleton_tree/create_tree.rs line 201 at r1 (raw file):

    /// 'Plants' the given smaller tree at the lowest leftmost node in order to create a tree of
    /// height TREE_HEIGHT::MAX.
    pub(crate) fn create_actual_sized_tree_from_smaller_tree(

this function still isn't used here, correct? please remove it (see comment in previous PR)

Code quote:

create_actual_sized_tree_from_smaller_tree

@nimrod-starkware nimrod-starkware force-pushed the nimrod/tree_height/small_tree_test branch from d92462d to 0e1bf97 Compare June 2, 2024 15:33
Copy link
Contributor Author

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @TzahiTaub)


crates/committer/src/patricia_merkle_tree/original_skeleton_tree/create_tree.rs line 201 at r1 (raw file):

Previously, dorimedini-starkware wrote…

this function still isn't used here, correct? please remove it (see comment in previous PR)

removed it

@nimrod-starkware nimrod-starkware force-pushed the nimrod/tree_height/remove_tree_height_field_from_original_skeleton branch from 416fb4d to b4cc3f8 Compare June 2, 2024 15:39
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

@nimrod-starkware nimrod-starkware force-pushed the nimrod/tree_height/small_tree_test branch 2 times, most recently from b5e5968 to 7a3df56 Compare June 3, 2024 06:56
@nimrod-starkware nimrod-starkware force-pushed the nimrod/tree_height/remove_tree_height_field_from_original_skeleton branch 2 times, most recently from f4bfe97 to 9711ca8 Compare June 3, 2024 06:59
@nimrod-starkware nimrod-starkware changed the base branch from nimrod/tree_height/small_tree_test to main June 3, 2024 07:00
@nimrod-starkware nimrod-starkware force-pushed the nimrod/tree_height/remove_tree_height_field_from_original_skeleton branch from 9711ca8 to 7c92538 Compare June 3, 2024 07:02
@nimrod-starkware nimrod-starkware force-pushed the nimrod/tree_height/remove_tree_height_field_from_original_skeleton branch from 7c92538 to 93998ed Compare June 3, 2024 07:08
@nimrod-starkware nimrod-starkware added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit 907b4d2 Jun 3, 2024
10 of 11 checks passed
@nimrod-starkware nimrod-starkware deleted the nimrod/tree_height/remove_tree_height_field_from_original_skeleton branch June 3, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants