chore(skeleton): hide private field in EdgePathLength

[TzahiTaub]

This change is 

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 71.42857% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 61.74%. Comparing base (907b4d2) to head (4ddfc01).

Files	Patch %	Lines
...src/patricia_merkle_tree/filled_tree/node_serde.rs	0.00%	1 Missing and 1 partial ⚠️
...ted_skeleton_tree/compute_updated_skeleton_tree.rs	0.00%	1 Missing and 1 partial ⚠️
...itter/src/patricia_merkle_tree/node_data/errors.rs	0.00%	1 Missing ⚠️
...r/src/patricia_merkle_tree/node_data/inner_node.rs	91.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   61.69%   61.74%   +0.05%     
==========================================
  Files          36       36              
  Lines        1650     1660      +10     
  Branches     1650     1660      +10     
==========================================
+ Hits         1018     1025       +7     
- Misses        583      585       +2     
- Partials       49       50       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dorimedini-starkware]

Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @TzahiTaub)

---

crates/committer/src/patricia_merkle_tree/test_utils.rs line 27 at r1 (raw file):

                    .expect("String is too large"),
            )
            .expect("Invalid length"),

this is a test util, right? unwrap is allowed and encouraged

Suggestion:

.unwrap()

---

crates/committer/src/patricia_merkle_tree/filled_tree/node_serde.rs line 119 at r1 (raw file):

                    )
                    .into(),
                    length: EdgePathLength::new(value.0[EDGE_BYTES - 1]).expect("Illegal length"),

I wouldn't expect here, this is deserialization code, the caller should handle this error...
WDYT? non-blocking

Suggestion:

length: EdgePathLength::new(value.0[EDGE_BYTES - 1])?

[TzahiTaub]

Reviewable status: 14 of 16 files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware and @TzahiTaub)

---

crates/committer/src/patricia_merkle_tree/test_utils.rs line 27 at r1 (raw file):

Previously, dorimedini-starkware wrote…

this is a test util, right? unwrap is allowed and encouraged

Tried that, getting error: used unwrap()on aResult value from clippy.

---

crates/committer/src/patricia_merkle_tree/filled_tree/node_serde.rs line 119 at r1 (raw file):

Previously, dorimedini-starkware wrote…

I wouldn't expect here, this is deserialization code, the caller should handle this error...
WDYT? non-blocking

I think there's a lot of work we need to do to propagate errors. Is this one OK specifically for where you pointed to?

[TzahiTaub]

Reviewable status: 14 of 16 files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware and @TzahiTaub)

---

crates/committer/src/patricia_merkle_tree/test_utils.rs line 27 at r1 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

Tried that, getting error: used unwrap()on aResult value from clippy.

Maybe becasue this module is used with feature="testing" and not just test?

[dorimedini-starkware]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

---

crates/committer/src/patricia_merkle_tree/test_utils.rs line 27 at r1 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

Maybe becasue this module is used with feature="testing" and not just test?

ah... is this needed from the cli area?

[TzahiTaub]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

---

crates/committer/src/patricia_merkle_tree/test_utils.rs line 27 at r1 (raw file):

Previously, dorimedini-starkware wrote…

ah... is this needed from the cli area?

@AvivYossef-starkware ?

[AvivYossef-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

---

crates/committer/src/patricia_merkle_tree/test_utils.rs line 27 at r1 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

@AvivYossef-starkware ?

You are right. feature="testing"is not like a test.
However, You can use the snippet on your test function and clippy will allow use of unwrap

Code snippet:

#[allow(clippy::unwrap_used)]

[dorimedini-starkware]

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)