Skip to content

feat: implement is_empty for UpdatedSkeletonTreeImpl #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Jun 2, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 62.01%. Comparing base (15f126d) to head (f72c995).

Files Patch % Lines
...patricia_merkle_tree/updated_skeleton_tree/tree.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
- Coverage   62.27%   62.01%   -0.27%     
==========================================
  Files          35       35              
  Lines        1662     1669       +7     
  Branches     1662     1669       +7     
==========================================
  Hits         1035     1035              
- Misses        578      585       +7     
  Partials       49       49              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dorimedini-starkware dorimedini-starkware force-pushed the dori/implement-silly-todo branch from 4f9bfd6 to f72c995 Compare June 2, 2024 10:04
Copy link
Contributor

@TzahiTaub TzahiTaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)


crates/committer/src/patricia_merkle_tree/updated_skeleton_tree/tree.rs line 86 at r2 (raw file):

    fn is_empty(&self) -> bool {
        let empty = self.skeleton_tree.is_empty();

non blocking, I like it better with the is prefix

Suggestion:

let is_empty

Signed-off-by: Dori Medini <dori@starkware.co>
@dorimedini-starkware dorimedini-starkware force-pushed the dori/implement-silly-todo branch from f72c995 to 4db1db7 Compare June 2, 2024 11:32
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)


crates/committer/src/patricia_merkle_tree/updated_skeleton_tree/tree.rs line 86 at r2 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

non blocking, I like it better with the is prefix

done

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Jun 2, 2024
Merged via the queue into main with commit 880da1d Jun 2, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants