Skip to content

refactor: remove unnecessary allow dead code #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

AvivYossef-starkware
Copy link
Collaborator

@AvivYossef-starkware AvivYossef-starkware commented Jun 2, 2024

Now we can see what really not in use and considering delete it.\


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 62.27%. Comparing base (2e6de49) to head (e3040a1).

Files Patch % Lines
...ted_skeleton_tree/compute_updated_skeleton_tree.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #170   +/-   ##
=======================================
  Coverage   62.27%   62.27%           
=======================================
  Files          35       35           
  Lines        1662     1662           
  Branches     1662     1662           
=======================================
  Hits         1035     1035           
  Misses        578      578           
  Partials       49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 25 of 25 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)


crates/committer/src/patricia_merkle_tree/node_data/leaf.rs line 27 at r1 (raw file):

}
#[derive(Clone, Debug, Eq, PartialEq)]
pub struct ContractState {

newline

Suggestion:

}

#[derive(Clone, Debug, Eq, PartialEq)]
pub struct ContractState {

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/test_filled_forest_client branch from ffc6b58 to 9077e91 Compare June 2, 2024 09:30
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/test_filled_forest_client branch from 9077e91 to e3040a1 Compare June 2, 2024 09:32
Copy link
Collaborator Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 18 of 25 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)


crates/committer/src/patricia_merkle_tree/node_data/leaf.rs line 27 at r1 (raw file):

Previously, dorimedini-starkware wrote…

newline

Done.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

@AvivYossef-starkware AvivYossef-starkware added this pull request to the merge queue Jun 2, 2024
Merged via the queue into main with commit 15f126d Jun 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants