-
Notifications
You must be signed in to change notification settings - Fork 0
fix(skeleton): add missing NodeIndex::new ctor calls #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(skeleton): add missing NodeIndex::new ctor calls #165
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
=======================================
Coverage 60.29% 60.29%
=======================================
Files 34 34
Lines 1511 1511
Branches 1511 1511
=======================================
Hits 911 911
Misses 559 559
Partials 41 41 ☔ View full report in Codecov by Sentry. |
58e596f
to
93d4d41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TzahiTaub)
crates/committer/src/patricia_merkle_tree/types.rs
line 113 at r2 (raw file):
let post_common_prefix_len = NodeIndex::new(xor).bit_length(); let lca = adapted_self.0 >> post_common_prefix_len; NodeIndex::new(lca)
please make the U256 in NodeIndex a private field so the compiler catches these constructions without new
.
if you need access to the inner U256 add a getter
Code quote:
NodeIndex::new(lca)
93d4d41
to
af43d6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
crates/committer/src/patricia_merkle_tree/types.rs
line 113 at r2 (raw file):
Previously, dorimedini-starkware wrote…
please make the U256 in NodeIndex a private field so the compiler catches these constructions without
new
.
if you need access to the inner U256 add a getter
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)
This change is