Skip to content

chore(skeleton): skeleton Edge from struct to tuple struct #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2024

Conversation

TzahiTaub
Copy link
Contributor

@TzahiTaub TzahiTaub commented May 28, 2024

This change is Reviewable

@TzahiTaub TzahiTaub self-assigned this May 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.58%. Comparing base (7a04d1b) to head (9fb3f07).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
- Coverage   67.94%   61.58%   -6.37%     
==========================================
  Files          35       35              
  Lines        1307     1468     +161     
  Branches     1307     1468     +161     
==========================================
+ Hits          888      904      +16     
- Misses        377      531     +154     
+ Partials       42       33       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

@TzahiTaub TzahiTaub added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit a968a54 May 29, 2024
19 checks passed
@TzahiTaub TzahiTaub deleted the tzahi/skeleton/skeleton_edge_to_tuple_struct branch May 29, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants