refactor: make some order in error types

[nimrod-starkware]

This change is 

[dorimedini-starkware]

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @amosStarkware and @nimrod-starkware)

---

crates/committer/src/forest_errors.rs line 8 at r1 (raw file):

use thiserror::Error;
pub(crate) type ForestResult<T> = Result<T, ForestError<LeafDataImpl>>;

newline after uses

Suggestion:

use thiserror::Error;

pub(crate) type ForestResult<T> = Result<T, ForestError<LeafDataImpl>>;

---

crates/committer/src/forest_errors.rs line 31 at r1 (raw file):

    #[error("Can't fill storage trie, because there is no updated skeleton at address {0:?}")]
    MissingUpdatedSkeleton(ContractAddress),
}

no need for extra indirection

Suggestion:

    #[error("Can't build storage trie's updated skeleton, because there is no original skeleton at address {0:?}")]
    MissingOriginalSkeleton(ContractAddress),
    #[allow(dead_code)]
    #[error("Can't fill storage trie, because there is no updated skeleton at address {0:?}")]
    MissingUpdatedSkeleton(ContractAddress),
}

[nimrod-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @amosStarkware and @dorimedini-starkware)

---

crates/committer/src/forest_errors.rs line 8 at r1 (raw file):

Previously, dorimedini-starkware wrote…

newline after uses

Done.

---

crates/committer/src/forest_errors.rs line 31 at r1 (raw file):

Previously, dorimedini-starkware wrote…

no need for extra indirection

Done.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 40.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 61.44%. Comparing base (2ef9eac) to head (8f294f3).

Files	Patch %	Lines
...ter/src/patricia_merkle_tree/filled_tree/forest.rs	0.00%	4 Missing ⚠️
...kle_tree/original_skeleton_tree/skeleton_forest.rs	72.72%	0 Missing and 3 partials ⚠️
...rkle_tree/updated_skeleton_tree/skeleton_forest.rs	0.00%	3 Missing ⚠️
crates/committer/src/block_committer/commit.rs	0.00%	1 Missing ⚠️
crates/committer/src/forest_errors.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
- Coverage   61.58%   61.44%   -0.14%     
==========================================
  Files          35       36       +1     
  Lines        1442     1442              
  Branches     1442     1442              
==========================================
- Hits          888      886       -2     
  Misses        512      512              
- Partials       42       44       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dorimedini-starkware]

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware)