Skip to content

fix: original skeleton forest test fix #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2024

Conversation

nimrod-starkware
Copy link
Contributor

@nimrod-starkware nimrod-starkware commented May 27, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.03%. Comparing base (980bd2f) to head (fdb8d3e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #154   +/-   ##
=======================================
  Coverage   67.03%   67.03%           
=======================================
  Files          35       35           
  Lines        1277     1277           
  Branches     1277     1277           
=======================================
  Hits          856      856           
  Misses        379      379           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

Copy link
Contributor

@TzahiTaub TzahiTaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)


crates/committer/src/patricia_merkle_tree/original_skeleton_tree/skeleton_forest_test.rs line 62 at r1 (raw file):

///               *         B                       B    ES
///              /         /  \                    / \    \
///             152       NZ   54                 NZ  47   NZ

UnmodifiedBottom

Suggestion:

UB

Copy link
Contributor Author

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TzahiTaub)


crates/committer/src/patricia_merkle_tree/original_skeleton_tree/skeleton_forest_test.rs line 62 at r1 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

UnmodifiedBottom

Done.

@nimrod-starkware nimrod-starkware force-pushed the nimrod/fix_forest_test branch 2 times, most recently from 2255a81 to 0e4f6a7 Compare May 28, 2024 06:26
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TzahiTaub)

@nimrod-starkware nimrod-starkware added this pull request to the merge queue May 28, 2024
Copy link
Contributor

@TzahiTaub TzahiTaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

@nimrod-starkware nimrod-starkware removed this pull request from the merge queue due to a manual request May 28, 2024
@nimrod-starkware nimrod-starkware force-pushed the nimrod/fix_forest_test branch from 0e4f6a7 to fdb8d3e Compare May 28, 2024 07:28
@nimrod-starkware nimrod-starkware added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit 9e51f36 May 28, 2024
10 of 11 checks passed
@TzahiTaub
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants