-
Notifications
You must be signed in to change notification settings - Fork 0
fix: original skeleton forest test fix #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
=======================================
Coverage 67.03% 67.03%
=======================================
Files 35 35
Lines 1277 1277
Branches 1277 1277
=======================================
Hits 856 856
Misses 379 379
Partials 42 42 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)
crates/committer/src/patricia_merkle_tree/original_skeleton_tree/skeleton_forest_test.rs
line 62 at r1 (raw file):
/// * B B ES /// / / \ / \ \ /// 152 NZ 54 NZ 47 NZ
UnmodifiedBottom
Suggestion:
UB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TzahiTaub)
crates/committer/src/patricia_merkle_tree/original_skeleton_tree/skeleton_forest_test.rs
line 62 at r1 (raw file):
Previously, TzahiTaub (Tzahi) wrote…
UnmodifiedBottom
Done.
2255a81
to
0e4f6a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TzahiTaub)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)
0e4f6a7
to
fdb8d3e
Compare
Suggestion: E |
This change is