Skip to content

chore(skeleton): add tree_height to UpdatedSkeleton #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2024

Conversation

TzahiTaub
Copy link
Contributor

@TzahiTaub TzahiTaub commented May 26, 2024

This change is Reviewable

@TzahiTaub TzahiTaub self-assigned this May 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 66.53%. Comparing base (73e3d80) to head (f4ce00d).

Files Patch % Lines
...ted_skeleton_tree/compute_updated_skeleton_tree.rs 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   66.43%   66.53%   +0.10%     
==========================================
  Files          35       35              
  Lines        1290     1294       +4     
  Branches     1290     1294       +4     
==========================================
+ Hits          857      861       +4     
  Misses        393      393              
  Partials       40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TzahiTaub TzahiTaub force-pushed the tzahi/skeleton/add_tree_height_to_updated branch from 5726be5 to f4ce00d Compare May 26, 2024 08:56
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

@TzahiTaub TzahiTaub added this pull request to the merge queue May 26, 2024
Merged via the queue into main with commit 6406580 May 26, 2024
11 checks passed
@TzahiTaub TzahiTaub deleted the tzahi/skeleton/add_tree_height_to_updated branch May 26, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants