Skip to content

chore!: move file contents to correct location #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2024

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented May 20, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.10%. Comparing base (e9f7e32) to head (77f76b9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   73.10%   73.10%           
=======================================
  Files          30       30           
  Lines        1071     1071           
  Branches     1071     1071           
=======================================
  Hits          783      783           
  Misses        251      251           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TzahiTaub TzahiTaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware)

@dorimedini-starkware dorimedini-starkware force-pushed the dori/remove-data-from-skeleton-leaf branch 3 times, most recently from dcadc7a to de2cc61 Compare May 20, 2024 12:27
@dorimedini-starkware dorimedini-starkware force-pushed the dori/move-file-contents-to-correct-place branch from c1d3fcc to 5e823fa Compare May 20, 2024 12:28
@dorimedini-starkware dorimedini-starkware changed the base branch from dori/remove-data-from-skeleton-leaf to main May 20, 2024 12:28
Signed-off-by: Dori Medini <dori@starkware.co>
@dorimedini-starkware dorimedini-starkware force-pushed the dori/move-file-contents-to-correct-place branch from 5e823fa to 77f76b9 Compare May 20, 2024 12:30
Copy link
Contributor

@TzahiTaub TzahiTaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r2, 5 of 5 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware)

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue May 20, 2024
Merged via the queue into main with commit a398ce3 May 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants