Skip to content

chore: move tree creation logic from source tree to target tree traits #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented May 16, 2024

This change is Reviewable

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 79.68750% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 76.91%. Comparing base (1530f51) to head (e57c9df).
Report is 7 commits behind head on main.

Files Patch % Lines
...itter/src/patricia_merkle_tree/filled_tree/tree.rs 82.50% 9 Missing and 12 partials ⚠️
...patricia_merkle_tree/updated_skeleton_tree/tree.rs 37.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   75.81%   76.91%   +1.09%     
==========================================
  Files          26       26              
  Lines         947      966      +19     
  Branches      947      966      +19     
==========================================
+ Hits          718      743      +25     
+ Misses        195      189       -6     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Dori Medini <dori@starkware.co>
@dorimedini-starkware dorimedini-starkware force-pushed the dori/move-creation-logic-to-target-trait branch from e57c9df to 0d4b104 Compare May 16, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants