build: filled forest

[AvivYossef-starkware]

This change is 

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 70.60%. Comparing base (b5df579) to head (5a664e1).

Files	Patch %	Lines
...ter/src/patricia_merkle_tree/filled_tree/forest.rs	0.00%	19 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
- Coverage   71.83%   70.60%   -1.24%     
==========================================
  Files          31       32       +1     
  Lines        1090     1109      +19     
  Branches     1090     1109      +19     
==========================================
  Hits          783      783              
- Misses        270      289      +19     
  Partials       37       37              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dorimedini-starkware]

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @amosStarkware and @AvivYossef-starkware)

---

crates/committer/src/patricia_merkle_tree/filled_tree/forest.rs line 14 at r2 (raw file):

    #[allow(dead_code)]
    /// Serialize each tree and store it.
    fn write_to_storage(&self, storage: &mut S);

does this work?

Suggestion:

pub(crate) trait FilledForest<L: LeafData> {
    #[allow(dead_code)]
    /// Serialize each tree and store it.
    fn write_to_storage(&self, storage: &mut impl Storage);

---

crates/committer/src/patricia_merkle_tree/filled_tree/forest.rs line 21 at r2 (raw file):

}

pub(crate) struct FilledForestImpl<L: LeafData + DBObject, T: FilledTree<L>> {

Suggestion:

<L: LeafData

---

crates/committer/src/patricia_merkle_tree/filled_tree/forest.rs line 28 at r2 (raw file):

}

impl<L: LeafData + DBObject, T: FilledTree<L>, S: Storage> FilledForest<L, S>

Suggestion:

L: LeafData

---

crates/committer/src/patricia_merkle_tree/filled_tree/forest.rs line 43 at r2 (raw file):

        // Store the contract tree.
        storage.mset(self.contract_tree.serialize());
    }

I am assuming that setting to storage is not a "local" operation, so I prefer to parallelize all sets to a single op.
to that end, I would construct an iterator over all new values and call mset once only.

Suggestion:

    #[allow(dead_code)]
    fn write_to_storage(&self, storage: &mut S) {
        let new_db_objects = self
            .storage_trees
            .values()
            .iter()
            // Serialize each storage tree and store it in the storage object.
            .flat_map(|tree| tree.serialize().iter())
            // Store the compiled class tree.
            .chain(self.compiled_class_tree.serialize().iter())
            // Store the contract tree.
            .chain(self.contract_tree.serialize().iter());
        storage.mset(new_db_objects.collect());
    }

[dorimedini-starkware]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware)

[dorimedini-starkware]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware)