Skip to content

[Minor] Migrate to logger.warning usage #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

emmanuel-ferdman
Copy link
Contributor

Description

The logger.warn method is deprecated so the library throws different deprecation warning:

/home/runner/work/pyvene/pyvene/pyvene/models/intervenable_base.py:72: DeprecationWarning: The 'warn' function is deprecated, use 'warning' instead

It also fixes a few typos along the way.

Testing Done

Run tests.

Checklist:

  • My PR title strictly follows the format: [Your Priority] Your Title
  • I have attached the testing log above
  • I provide enough comments to my code
  • I have changed documentations
  • I have added tests for my changes

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
@frankaging
Copy link
Collaborator

Thanks! LGTM!

Copy link
Collaborator

@frankaging frankaging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship It!

@frankaging frankaging merged commit dad20d8 into stanfordnlp:main Apr 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants