Replace datasets hasher with python hashlib #8550
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenmoneygithub
force-pushed
the
fix-hash
branch
from
ee5be77 to
fbf6147
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the usage of datasets.fingerprint.Hasher with Python's built-in hashlib to remove the dependency on the datasets library, which is no longer required for DSPy.
- Replaces
datasets.fingerprint.Hasherwithhashlib.sha256for hash generation - Adds
ujsonimport and usage for JSON serialization before hashing - Updates two files that were using the datasets hasher in their critical path
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| dspy/teleprompt/bootstrap.py | Replaces datasets hasher with hashlib for random seed generation in bootstrap sampling |
| dspy/clients/utils_finetune.py | Replaces datasets hasher with hashlib for generating unique file names based on data hash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
datasetsis no longer a required dep for DSPy, so we should remove its usage from the critical path.