Skip to content

Pin json-repair for python 3.9 support #8251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

TomeHirata
Copy link
Collaborator

json-repair dropped the support for python 3.9 since 0.45.0. So we should pin json-repair<0.45.0 until we drop the support for python 3.9
mangiucugna/json_repair#124

@TomeHirata TomeHirata force-pushed the fix/pin-json-repair branch from 268877b to 5b4c394 Compare May 21, 2025 03:52
@TomeHirata
Copy link
Collaborator Author

0.45.0 is yanked

Copy link
Collaborator

@chenmoneygithub chenmoneygithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tomu! Maybe we should pin different version based on python type, like what we are doing for numpy:

    "numpy>=1.26.0,<2.2; python_version == '3.9'",
    "numpy>=1.26.0; python_version >= '3.10'",

@TomeHirata
Copy link
Collaborator Author

This PR is not needed since json_repair 0.45.0 is yanked

1 similar comment
@TomeHirata
Copy link
Collaborator Author

This PR is not needed since json_repair 0.45.0 is yanked

@TomeHirata TomeHirata closed this May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants