Run tests with extra dependencies separately #8246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am actually not sure if we need to split, with |
|
@chenmoneygithub This separation is necessary to test the core tests with the core dependencies of DSPy. While currently there is only one extra test, I'll move dataset and optimizer related tests into this step after removing pandas or optuna. |
pyproject.toml
Outdated
| ] | ||
| mcp = ["mcp; python_version >= '3.10'"] | ||
| full_test = [ |
There was a problem hiding this comment.
Sorry this one is on me, maybe we should make this as extras to the dev group?
So something like:
extended_test = [
"mcp; python_version >= '3.10'",
"pandas",
"datasets",
]
Then in the action we do uv sync -p .venv --extra dev --extra extended_test?
There was a problem hiding this comment.
I added a group called test_extras for adding all extras
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the ci pipeline installs all dependencies and runs all tests at a time. But we want to confirm if core tests are passed successfully with minimum dependencies. This PR separate the test steps into two; core dependencies and extra dependencies. This is a prerequisite for the upcoming separation of large dependencies.