Skip to content

Bugfix: Ensure keys in both entities are merged #8238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions dspy/utils/usage_tracker.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,11 @@ def _merge_usage_entries(self, usage_entry1, usage_entry2) -> dict[str, dict[str

result = dict(usage_entry2)
for k, v in usage_entry1.items():
if k in result:
if isinstance(v, dict):
result[k] = self._merge_usage_entries(result[k], v)
else:
result[k] = result[k] or 0
result[k] += v if v else 0
current_v = result.get(k)
if isinstance(v, dict):
result[k] = self._merge_usage_entries(current_v, v)
else:
result[k] = (current_v or 0) + (v or 0)
return result

def add_usage(self, lm: str, usage_entry: dict):
Expand Down
13 changes: 13 additions & 0 deletions tests/utils/test_usage_tracker.py
Original file line number Diff line number Diff line change
Expand Up @@ -157,3 +157,16 @@ def test_track_usage_context_manager():
assert "openai/gpt-4o-mini" in total_usage
assert len(total_usage.keys()) == 1
assert isinstance(total_usage["openai/gpt-4o-mini"], dict)


def test_merge_usage_entries_with_new_keys():
"""Ensure merging usage entries preserves unseen keys."""
tracker = UsageTracker()

tracker.add_usage("model-x", {"prompt_tokens": 5})
tracker.add_usage("model-x", {"completion_tokens": 2})

total_usage = tracker.get_total_tokens()

assert total_usage["model-x"]["prompt_tokens"] == 5
assert total_usage["model-x"]["completion_tokens"] == 2