Skip to content

Fix typo in comment in dspy/teleprompt/bettertogether.py #8236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 18, 2025
Merged

Fix typo in comment in dspy/teleprompt/bettertogether.py #8236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f470343
Fix typo in comment
estsauver May 17, 2025
ea15048
Merge pull request #1 from estsauver/codex/fix-typo-in-comment-near-b…
estsauver May 17, 2025
6964eb3
Fix typo in two_step_adapter docstring
estsauver May 17, 2025
32091f8
Merge pull request #2 from estsauver/codex/update-docstring-note-todo…
estsauver May 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dspy/adapters/two_step_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from dspy.signatures.signature import Signature, make_signature

"""
NOTE/TODO/FIMXE:
NOTE/TODO/FIXME:

The main issue below is that the second step's signature is entirely created on the fly and is invoked with a chat
adapter explicitly constructed with no demonstrations. This means that it cannot "learn" or get optimized.
Expand Down
2 changes: 1 addition & 1 deletion dspy/teleprompt/bettertogether.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def _compile_prompt_optimizer(self, student, trainset, valset_ratio) -> Program:
# predictor.lm attributes. In particular,
# BootstrapFewShotWithRandomSearch seems to be resetting these. We are
# manually re-setting the LMs here to circumvent this issue, but we
# should consider adressing it in BFRS.
# should consider addressing it in BFRS.
logger.info("Compiling the prompt optimizer...")
pred_lms = [pred.lm for pred in student.predictors()]
student = self.prompt_optimizer.compile(student, trainset=prompt_trainset, valset=prompt_valset)
Expand Down