Standardize coding style in DSPy #7885
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulgens
reviewed
Mar 5, 2025
| # Allow fix for all enabled rules (when `--fix`) is provided. | ||
| fixable = ["ALL"] | ||
| unfixable = [] | ||
|
|
||
| [tool.ruff.format] | ||
| docstring-code-format = false | ||
| quote-style = "double" |
There was a problem hiding this comment.
This is already the default value.
There was a problem hiding this comment.
yes, just want to explicitly note this out.
chenmoneygithub
force-pushed
the
standard-style
branch
from
575443f to
616c290
Compare
chenmoneygithub
force-pushed
the
standard-style
branch
from
88dafb0 to
71773a3
Compare
chenmoneygithub
force-pushed
the
standard-style
branch
from
71773a3 to
5375773
Compare
This was referenced May 6, 2025
This was referenced May 7, 2025
chenmoneygithub
force-pushed
the
standard-style
branch
from
4b8b8a3 to
3a9091e
Compare
This was referenced May 15, 2025
chenmoneygithub
force-pushed
the
standard-style
branch
from
e346030 to
1cfa4f5
Compare
chenmoneygithub
changed the title
chenmoneygithub
force-pushed
the
standard-style
branch
from
618423d to
d8e3454
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As one step towards stable package (DSPy 3.0), we will enforce the python style for easy maintenance and scalability.
This PR just contains the desired ruff rules, and we will make separate PRs to fix files according to the rule. After everything is fixed we will check in this PR and enable style check and pre-commit hook.