-
-
Notifications
You must be signed in to change notification settings - Fork 48
Expose builtin constraints #1494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1494 +/- ##
==========================================
+ Coverage 89.52% 89.55% +0.02%
==========================================
Files 66 66
Lines 9684 9695 +11
==========================================
+ Hits 8670 8682 +12
+ Misses 1014 1013 -1
🚀 New features to boost your workflow:
|
The expression test failures are kind of weird but they seem to be fixed by stan-dev/math#3147 so there might just be some known bug in offset_multipliers code (cc @SteveBronder) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few small comments but overall I think good!
Closes #1436
Submission Checklist
Release notes
All the built-in constraint types now have corresponding
_jacobian
,_constrain
, and_unconstrain
functions. The first two functions are identical except for the _jacobian version will increment the target with the necessary change of variables adjustment.Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)